Skip to content
This repository was archived by the owner on Jun 4, 2024. It is now read-only.

Issue 539 - Booleans not showing #593

Merged
merged 3 commits into from
Sep 23, 2019
Merged

Conversation

dmt0
Copy link
Contributor

@dmt0 dmt0 commented Sep 19, 2019

Fixes #539

Note, that this does not add bool as a supported type. Filtering won't work, since trying to search for true or false will just search for those strings. Sorting puts false before number 0, and true between numbers 0 and 1.

@chriddyp chriddyp temporarily deployed to dash-table-review-pr-593 September 19, 2019 18:52 Inactive
@dmt0 dmt0 self-assigned this Sep 19, 2019
@dmt0 dmt0 changed the title Booleans not showing Issue 539 - Booleans not showing Sep 19, 2019
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-593 September 19, 2019 20:05 Inactive
Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment on the vscode settings but otherwise this looks good.

@dmt0 dmt0 force-pushed the booleans-not-showing branch from 6a06495 to 65b9d18 Compare September 23, 2019 18:05
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-593 September 23, 2019 18:06 Inactive
@dmt0 dmt0 force-pushed the booleans-not-showing branch from 65b9d18 to 51674a1 Compare September 23, 2019 20:02
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-593 September 23, 2019 20:02 Inactive
Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks good. Welcome to the table @dmt0. Just need a branch update.

@dmt0
Copy link
Contributor Author

dmt0 commented Sep 23, 2019

Looks like I'm not authorized to merge.

@Marc-Andre-Rivet Marc-Andre-Rivet merged commit 224a27c into dev Sep 23, 2019
@Marc-Andre-Rivet Marc-Andre-Rivet deleted the booleans-not-showing branch September 23, 2019 23:04
shammamah-zz pushed a commit that referenced this pull request Sep 25, 2019
* Ensure booleans are showing

* Changelog entry
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boolean values not showing
3 participants