Issue 591 - Row and column selection with multiple tables #594
Conversation
- additional tests against tables without id
| return (this.state.tableProps2 ? <DataTable | ||
| {...this.state.tableProps2} | ||
| id={baseId ? 'table2' : baseId} | ||
| /> : null); |
There was a problem hiding this comment.
Change the 2 tables test behavior so that
- the props are not shared between the tables 🙄
- the 2nd table will have an
idonly if the 1st one has one
| type={rowSelectable === 'single' ? 'radio' : 'checkbox'} | ||
| style={{ verticalAlign: 'middle' }} | ||
| name='row-select' | ||
| name={`row-select-${id}`} |
There was a problem hiding this comment.
Use the table's id to make the group unique
| !allSelected | ||
| )} | ||
| name='column-header--select' | ||
| name={`column-select-${id}`} |
There was a problem hiding this comment.
Use the table's id to make the group unique
| export default class DashTable { | ||
| static getCell(row: number, column: number, editable: State = State.Ready) { | ||
| return cy.get(`#table ${getSelector(editable)} tbody tr td.column-${column}`).eq(row); | ||
| export class DashTableHelper { |
There was a problem hiding this comment.
Generalize the helper to work for multiple tables - Leaving the static implementation below for existing tests
| }); | ||
| }); | ||
|
|
||
| describe('select rows & columns in multiple tables without id', () => { |
There was a problem hiding this comment.
Renamed the file to take into consideration that there are now rows and columns tests.
Create two tables without ids and check that row and column selections are not shared between them.
tests/cypress/src/DashTable.ts
Outdated
| } | ||
|
|
||
| export default class DashTable { | ||
| private static __helper = new DashTableHelper('table'); |
There was a problem hiding this comment.
would it not work to just say export default const DashTable = new DashTableHelper('table');?
There was a problem hiding this comment.
😞 very much so
alexcjohnson
left a comment
alexcjohnson
left a comment
There was a problem hiding this comment.
Looks great. Just one question about 🌴 but since it's just in the 🐅 it's non-⛔️
💃
Fixes #591