Skip to content

Remove unused Misc class #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kamil-tekiela wants to merge 2 commits into from
Closed

Remove unused Misc class #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a2d861
Remove unused Misc class
kamil-tekiela May 31, 2023
e60c36d
Update baselines
kamil-tekiela May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1185,16 +1185,6 @@ parameters:
count: 1
path: tests/Parser/WithStatementTest.php

-
message: "#^Parameter \\#1 \\$statement of static method PhpMyAdmin\\\\SqlParser\\\\Utils\\\\Misc\\:\\:getAliases\\(\\) expects PhpMyAdmin\\\\SqlParser\\\\Statements\\\\SelectStatement, PhpMyAdmin\\\\SqlParser\\\\Statement\\|null given\\.$#"
count: 1
path: tests/Utils/MiscTest.php

-
message: "#^Parameter \\#2 \\$database of static method PhpMyAdmin\\\\SqlParser\\\\Utils\\\\Misc\\:\\:getAliases\\(\\) expects string, string\\|null given\\.$#"
count: 1
path: tests/Utils/MiscTest.php

-
message: "#^Parameter \\#2 \\$list of static method PhpMyAdmin\\\\SqlParser\\\\Utils\\\\Query\\:\\:getClause\\(\\) expects PhpMyAdmin\\\\SqlParser\\\\TokensList, PhpMyAdmin\\\\SqlParser\\\\TokensList\\|null given\\.$#"
count: 9
Expand Down
34 changes: 10 additions & 24 deletions psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<files psalm-version="5.11.0@c9b192ab8400fdaf04b2b13d110575adc879aa90">
<files psalm-version="5.12.0@f90118cdeacd0088e7215e64c0c99ceca819e176">
<file src="src/Components/AlterOperation.php">
<ArgumentTypeCoercion>
<code><![CDATA[$component->partitions]]></code>
Expand Down Expand Up @@ -191,9 +191,6 @@
<InvalidArgument>
<code><![CDATA[$options['breakOnParentheses']]]></code>
</InvalidArgument>
<InvalidAttribute>
<code>\AllowDynamicProperties</code>
</InvalidAttribute>
<MixedArrayOffset>
<code><![CDATA[Parser::$statementParsers[$token->keyword]]]></code>
<code><![CDATA[self::$allowedKeywords[$token->keyword]]]></code>
Expand Down Expand Up @@ -236,6 +233,9 @@
<TypeDoesNotContainType>
<code><![CDATA[empty($options['field'])]]></code>
</TypeDoesNotContainType>
<UndefinedAttributeClass>
<code>\AllowDynamicProperties</code>
</UndefinedAttributeClass>
</file>
<file src="src/Components/ExpressionArray.php">
<InvalidArgument>
Expand Down Expand Up @@ -4905,6 +4905,9 @@
<code>getNextOfType</code>
<code>getNextOfType</code>
</PossiblyNullReference>
<UnsupportedPropertyReferenceUsage>
<code><![CDATA[$list = &$this->list]]></code>
</UnsupportedPropertyReferenceUsage>
</file>
<file src="src/Statement.php">
<DocblockTypeContradiction>
Expand All @@ -4914,9 +4917,6 @@
<code>$built[$field]</code>
<code><![CDATA[$parsedClauses[$token->value]]]></code>
</InvalidArgument>
<InvalidAttribute>
<code>\AllowDynamicProperties</code>
</InvalidAttribute>
<MethodSignatureMustProvideReturnType>
<code>__toString</code>
</MethodSignatureMustProvideReturnType>
Expand Down Expand Up @@ -4952,6 +4952,9 @@
<TypeDoesNotContainType>
<code>count($clauses) === 0</code>
</TypeDoesNotContainType>
<UndefinedAttributeClass>
<code>\AllowDynamicProperties</code>
</UndefinedAttributeClass>
<UnusedForeachValue>
<code>$index</code>
</UnusedForeachValue>
Expand Down Expand Up @@ -5423,14 +5426,6 @@
<code><![CDATA[$curr->type === Token::TYPE_KEYWORD]]></code>
</RedundantConditionGivenDocblockType>
</file>
<file src="src/Utils/Misc.php">
<DocblockTypeContradiction>
<code>! ($statement instanceof SelectStatement)</code>
</DocblockTypeContradiction>
<PossiblyNullArrayOffset>
<code>$tables[$thisDb]</code>
</PossiblyNullArrayOffset>
</file>
<file src="src/Utils/Query.php">
<InvalidNullableReturnType>
<code>int</code>
Expand Down Expand Up @@ -5747,15 +5742,6 @@
<code>setAccessible</code>
</UnusedMethodCall>
</file>
<file src="tests/Utils/MiscTest.php">
<ArgumentTypeCoercion>
<code>$statement</code>
</ArgumentTypeCoercion>
<PossiblyNullArgument>
<code>$db</code>
<code>$statement</code>
</PossiblyNullArgument>
</file>
<file src="tests/Utils/QueryTest.php">
<PossiblyNullArgument>
<code><![CDATA[$parser->list]]></code>
Expand Down
98 changes: 0 additions & 98 deletions src/Utils/Misc.php
View file
Open in desktop

This file was deleted.

137 changes: 0 additions & 137 deletions tests/Utils/MiscTest.php
View file
Open in desktop

This file was deleted.