Skip to content

Conversation

@kamil-tekiela
Copy link
Contributor

I have started analysing this repo. I noticed a lot of issues and I will make PRs for them slowly. Please carefully review my work as I am only starting with this repo, but I would love to modernize it just like the main PMA project. If there are any particular guidelines I should keep in mind, please let me know.

Signed-off-by: Kamil Tekiela <[email protected]>
Signed-off-by: Kamil Tekiela <[email protected]>
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (64090cb) 96.66% compared to head (e60c36d) 96.63%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #451      +/-   ##
============================================
- Coverage     96.66%   96.63%   -0.03%     
+ Complexity     2198     2173      -25     
============================================
  Files            67       66       -1     
  Lines          5062     5023      -39     
============================================
- Hits           4893     4854      -39     
  Misses          169      169              

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@williamdes
Copy link
Member

Did you check that upstream phpMyAdmin does not use the code?

This is the right branch tor breaking stuff anyway, feel free to add a changelog entry too

@kamil-tekiela
Copy link
Contributor Author

Did you check that upstream phpMyAdmin does not use the code?

This is the right branch tor breaking stuff anyway, feel free to add a changelog entry too

Ohh, you are right. This could be used there. Let me quickly check.

@kamil-tekiela
Copy link
Contributor Author

Yeah, you are absolutely right. It's used here https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/classes/Controllers/Export/ExportController.php#L211

Is there any particular reason why this function is in sql-parser repo? I will close this PR and maybe I will try to refactor this class in another PR.

@kamil-tekiela kamil-tekiela deleted the Misc branch May 31, 2023 20:49
@kamil-tekiela kamil-tekiela mentioned this pull request May 31, 2023
@williamdes williamdes self-assigned this Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants