Fix building of RenameStatement #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The nuance here is that we don't treat `RENAME TABLE` as the keyword of the clause, only `RENAME` is considered. * That's why we can't use `Statement::$CLAUSES` directly here (even with value of `3` (see `Statement::$CLAUSES`)) * Providing an overriden definition of `build()` in RenameStatement Signed-off-by: Deven Bansod <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
============================================
+ Coverage 99.75% 99.75% +<.01%
- Complexity 1732 1733 +1
============================================
Files 58 58
Lines 4135 4137 +2
============================================
+ Hits 4125 4127 +2
Misses 10 10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RENAME TABLEas the keyword of the clause, onlyRENAMEis considered.Statement::$CLAUSESdirectly here (even with value of3(seeStatement::$CLAUSES))build()in RenameStatementFix #201
Signed-off-by: Deven Bansod [email protected]