Feature/kotlin serialization #393
Merged
+1,548
−1,041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ⏺ Configure ABI validation in subprojects and add CI check - Add apiCheck task to GitHub Actions static analysis workflow - Demo project excluded from API check * Apply apiCheck plugin on a per-module basis until we solidify Gradle best practices for making plugin declarations DRY.
- serialize request using kotlin serialization in confirm-payment-source - integrate kotlin serialization with TrackingEventsAPI
- Remove PaymentsJSON.kt - Migrate to typed data classes for the response - simplify CardResponseParser.kt
- added GraphQLResponse, GraphQLRequest - used kotlin serialization for serialization and deserialization in GraphQLClient - migrated DataVaultPaymentMethodTokensAPI to use kotlin serialization and strong data types - update API - change extensions to generic JSONObject - handle non 200 response from graphQL
* Migrate Demo app to Kotlin Serialization - Add kotlinx.serialization plugin and dependencies - Create strongly-typed serializable models for API requests and responses - Implement KotlinSerializationConverterFactory for Retrofit - Update API services to use typed request/response models - Replace manual JSON parsing with automatic deserialization - Update all use cases to use the new serialization models * fix detekt issues * rename properties to match name in Request/Response structure
sshropshire
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Checklist
Authors