Migrate GraphQL serialization to kotlin serialization #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- used kotlin serialization for serialization and deserialization in GraphQLClient - migrated DataVaultPaymentMethodTokensAPI to use kotlin serialization and strong data types
sshropshire
reviewed
Sep 11, 2025
| data class GraphQLRequest<V>( | ||
| val query: String, | ||
| val variables: V? = null, | ||
| @kotlinx.serialization.Transient |
There was a problem hiding this comment.
Hey what does @kotlinx.serialization.Transient do?
There was a problem hiding this comment.
it tells serializer not to serialize property
There was a problem hiding this comment.
Oh ok. Do we actually need this property? It looks like it's always null.
sshropshire
reviewed
Sep 11, 2025
CorePayments/src/main/java/com/paypal/android/corepayments/graphql/GraphQLClient.kt
Show resolved
Hide resolved
sshropshire
reviewed
Sep 11, 2025
CorePayments/src/main/java/com/paypal/android/corepayments/graphql/GraphQLClient.kt
Show resolved
Hide resolved
sshropshire
reviewed
Sep 11, 2025
CorePayments/src/main/java/com/paypal/android/corepayments/graphql/GraphQLClient.kt
Show resolved
Hide resolved
sshropshire
reviewed
Sep 11, 2025
CorePayments/src/main/java/com/paypal/android/corepayments/graphql/GraphQLClient.kt
Outdated
Show resolved
Hide resolved
sshropshire
approved these changes
Sep 11, 2025
| expiry = cardExpiry, | ||
| name = card.cardholderName, | ||
| securityCode = card.securityCode, | ||
| billingAddress = vaultBillingAddress |
There was a problem hiding this comment.
We don't have billingAddress for Card in iOS for vaulting.
I wonder if that's a requirement.
Maybe we need to add it as an optional field.
The endpoint works without it.
There was a problem hiding this comment.
it is an optional field, nullable in kotlin
KunJeongPark
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Checklist
Authors