-
Notifications
You must be signed in to change notification settings - Fork 3k
feat(richtext-lexical): upgrade lexical from 0.28.0 to 0.34.0 #13622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
@GermanJablo You'll need to go through the release notes to call them out so we can link to those for our release notes. |
I've updated the PR description @DanRibbens. Does this seem okay to you? |
@GermanJablo Historically for lexical bumps, given that we still have large chunks of code that are similar to the lexical playground, I went through the lexical playground commits and ported over all relevant changes to payload (e.g. see #11764). That way, we stay up to date on new / deprecated APIs or broken / improved functionality. Also caught a lot of bugs that way. Could you do that here, or in a separate PR? Same thing for lexical/react - we took some code from there, like the link feature. |
…n methods with selection-based alternatives
Ok, I've reviewed and ported all the relevant changes. Only two tasks remain (I've already added them to Asana):
This PR should be ready to go. |
🚀 This is included in version v3.55.0 |
Fixes #13386
Below I write a clarification to copy and paste into the release note, based on our latest upgrade of Lexical in v3.29.0.
Important
This release upgrades the lexical dependency from 0.28.0 to 0.34.0.
If you installed lexical manually, update it to 0.34.0. Installing lexical manually is not recommended, as it may break between updates, and our re-exported versions should be used. See the yellow banner box for details.
If you still encounter richtext-lexical errors, do the following, in this order:
Lexical Breaking Changes
The following Lexical releases describe breaking changes. We recommend reading them if you're using Lexical APIs directly (
@payloadcms/richtext-lexical/lexical/*
).TODO: