Skip to content

refactor: lru-cache maxAge to ttl #8039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 13, 2022
Merged

refactor: lru-cache maxAge to ttl #8039

merged 3 commits into from
Jun 13, 2022

Conversation

Moumouls
Copy link
Member

New Pull Request Checklist

Issue Description

Close: #7985

Related issue: FILL_THIS_OUT

Approach

maxAge to ttl

TODOs before merging

  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • ❌ Please fill out all fields with a placeholder FILL_THIS_OUT, otherwise your pull request will be closed. If a field does not apply to the pull request, fill in n/a.

@Moumouls Moumouls requested a review from a team June 12, 2022 18:45
@codecov
Copy link

codecov bot commented Jun 12, 2022 •
edited
Loading

Codecov Report

Merging #8039 (eca9a94) into alpha (5f7d392) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            alpha    #8039   +/-   ##
=======================================
  Coverage   94.13%   94.14%           
=======================================
  Files         182      182           
  Lines       13659    13659           
=======================================
+ Hits        12858    12859    +1     
+ Misses        801      800    -1
Impacted Files Coverage Δ
src/Adapters/Cache/LRUCache.js 100.00% <ø> (ø)
src/LiveQuery/ParseLiveQueryServer.js 95.65% <ø> (ø)
src/LiveQuery/SessionTokenCache.js 86.95% <ø> (ø)
src/ParseServerRESTController.js 98.48% <0.00%> (+1.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f7d392...eca9a94. Read the comment docs.

dblythy
dblythy approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@dblythy dblythy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtrezza mtrezza mentioned this pull request Jun 13, 2022
Closed
mtrezza
mtrezza approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, waiting for CI to pass.

@Moumouls
Copy link
Member Author

@mtrezza what you think about increasing CI max time to 20min it seems that's too short for mongo 5.X

@mtrezza
Copy link
Member

mtrezza commented Jun 13, 2022 •
edited
Loading

We should rather look into why installing takes so long, otherwise we just keep spending resources. It's likely a dependency that's using an insecure protocol. Opened #8041 to fix this.

@mtrezza mtrezza merged commit 72fac8a into parse-community:alpha Jun 13, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.3.0-alpha.17

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jun 17, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.3.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 17, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

+1 more reviewer

@dblythy dblythy dblythy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Moumouls @mtrezza @parseplatformorg @dblythy