TST/CLN: Reuse top level fixtures instead of parametrizations #56583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Testing
|
Going to merge this in. Can follow up if needed |
|
It seems that the changes in ExtensionArray tests done here break testing of EAs in downstream packages. Those do not have access to fixtures defined in pandas conftest.py and since this PR relies on them, it breaks. See this outcome of GeoPandas CI using the latest nightly https://github.com/bnaul/geopandas/actions/runs/7402184055/job/20139507247. |
|
Sorry for the breakage. I opened up a PR in geopandas to fix this geopandas/geopandas#3121 Our distribution of ExtensionArray tests is still a big fragile; I see you had to define some additional fixtures previously that were in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.