Skip to content

TST: extension tests use its own fixtures #56889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jorisvandenbossche
Copy link
Member

This reverts a small part of #56583, for the changes made in the pandas/tests/extension directory

This is still a bit brittle, as there is currently no check inplace we don't change this back in the future -> #56735. I was thinking we could run the tests for one of our own extension arrays outside of the pandas tests, will comment more on the issue.

@jorisvandenbossche jorisvandenbossche added Testing pandas testing functions or related to the test suite ExtensionArray Extending pandas with custom dtypes or arrays. labels Jan 15, 2024
@jorisvandenbossche jorisvandenbossche added this to the 3.0 milestone Jan 15, 2024
@mroeschke mroeschke merged commit 5c67c96 into pandas-dev:main Jan 15, 2024
@mroeschke
Copy link
Member

Thanks @jorisvandenbossche

@jorisvandenbossche jorisvandenbossche deleted the tst-extension-fixtures branch January 15, 2024 19:10
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
TST: ensure extension tests use its own fixtures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants