Skip to content

CI: Fix botocore Error #34087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 9, 2020
Merged

CI: Fix botocore Error #34087

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a38e882
Update Error Msg
alimcmaster1 May 9, 2020
730256d
Fix botocore error
alimcmaster1 May 9, 2020
ae6139c
Add match pattern
alimcmaster1 May 9, 2020
0d78961
black
alimcmaster1 May 9, 2020
d43bb03
Add AWS Docs & Fix Parquet Test
alimcmaster1 May 9, 2020
f3be192
Docs
alimcmaster1 May 9, 2020
de6e45d
Docs
alimcmaster1 May 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions pandas/tests/io/parser/test_network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,17 +172,28 @@ def test_read_s3_fails(self):
def test_write_s3_csv_fails(self, tips_df):
# GH 32486
# Attempting to write to an invalid S3 path should raise
with pytest.raises(
FileNotFoundError, match="The specified bucket does not exist"
):
import botocore

# GH 34087
# https://boto3.amazonaws.com/v1/documentation/api/latest/guide/error-handling.html
# Catch a ClientError since AWS Service Errors are defined dynamically
error = (FileNotFoundError, botocore.exceptions.ClientError)

with pytest.raises(error, match="The specified bucket does not exist"):
tips_df.to_csv("s3://an_s3_bucket_data_doesnt_exit/not_real.csv")

@td.skip_if_no("pyarrow")
def test_write_s3_parquet_fails(self, tips_df):
# GH 27679
with pytest.raises(
FileNotFoundError, match="The specified bucket does not exist"
):
# Attempting to write to an invalid S3 path should raise
import botocore

# GH 34087
# https://boto3.amazonaws.com/v1/documentation/api/latest/guide/error-handling.html
# Catch a ClientError since AWS Service Errors are defined dynamically
error = (FileNotFoundError, botocore.exceptions.ClientError)

with pytest.raises(error, match="The specified bucket does not exist"):
tips_df.to_parquet("s3://an_s3_bucket_data_doesnt_exit/not_real.parquet")

def test_read_csv_handles_boto_s3_object(self, s3_resource, tips_file):
Expand Down