CI: Fix botocore Error #34087
Merged
CI: Fix botocore Error #34087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @alimcmaster1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-05-09 11:48:53 UTC |
|
also need to catch in test_write_s3_parquet_fails |
|
https://github.com/pandas-dev/pandas/pull/34087/checks?check_run_id=658833815 Fixed up parquet test too and added boto docs on dynamic errors here |
jreback
added
IO Parquet
jreback
approved these changes
May 9, 2020
|
thanks @alimcmaster1 for the quick response |
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
* Update Error Msg * Fix botocore error * Add match pattern * black * Add AWS Docs & Fix Parquet Test * Docs * Docs
simonjayhawkins
pushed a commit
to simonjayhawkins/pandas
that referenced
this pull request
May 14, 2020
* Update Error Msg * Fix botocore error * Add match pattern * black * Add AWS Docs & Fix Parquet Test * Docs * Docs
simonjayhawkins
added a commit
that referenced
this pull request
May 14, 2020
Co-authored-by: alimcmaster1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS Service Exceptions are not statically defined in boto3. Easiest to just catch a ClientError here.
Ref Docs:
https://boto3.amazonaws.com/v1/documentation/api/latest/guide/error-handling.html#parsing-error-responses-and-catching-exceptions-from-aws-services