Skip to content

TYPING: --disallow-any-expr for HTMLFormatter.__init__ #28140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pandas/io/formats/format.py
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,8 @@ def __init__(
decimal: str = ".",
table_id: Optional[str] = None,
render_links: bool = False,
**kwds
bold_rows: bool = False,
escape: bool = True,
):
self.frame = frame
self.show_index_names = index_names
Expand Down Expand Up @@ -580,7 +581,8 @@ def __init__(
else:
self.justify = justify

self.kwds = kwds
self.bold_rows = bold_rows
self.escape = escape

if columns is not None:
self.columns = ensure_index(columns)
Expand Down
8 changes: 4 additions & 4 deletions pandas/io/formats/html.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class HTMLFormatter(TableFormatter):
def __init__(
self,
formatter: DataFrameFormatter,
classes: Optional[Union[str, List, Tuple]] = None,
classes: Optional[Union[str, List[str], Tuple[str, ...]]] = None,
border: Optional[int] = None,
) -> None:
self.fmt = formatter
Expand All @@ -46,11 +46,11 @@ def __init__(
self.frame = self.fmt.frame
self.columns = self.fmt.tr_frame.columns
self.elements = [] # type: List[str]
self.bold_rows = self.fmt.kwds.get("bold_rows", False)
self.escape = self.fmt.kwds.get("escape", True)
self.bold_rows = self.fmt.bold_rows
self.escape = self.fmt.escape
self.show_dimensions = self.fmt.show_dimensions
if border is None:
border = get_option("display.html.border")
border = cast(int, get_option("display.html.border"))
self.border = border
self.table_id = self.fmt.table_id
self.render_links = self.fmt.render_links
Expand Down
5 changes: 3 additions & 2 deletions pandas/io/formats/latex.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,13 @@ def __init__(
):
self.fmt = formatter
self.frame = self.fmt.frame
self.bold_rows = self.fmt.kwds.get("bold_rows", False)
self.bold_rows = self.fmt.bold_rows
self.column_format = column_format
self.longtable = longtable
self.multicolumn = multicolumn
self.multicolumn_format = multicolumn_format
self.multirow = multirow
self.escape = self.fmt.escape

def write_result(self, buf: IO[str]) -> None:
"""
Expand Down Expand Up @@ -142,7 +143,7 @@ def pad_empties(x):
buf.write("\\endfoot\n\n")
buf.write("\\bottomrule\n")
buf.write("\\endlastfoot\n")
if self.fmt.kwds.get("escape", True):
if self.escape:
# escape backslashes first
crow = [
(
Expand Down