Skip to content

TYPING: --disallow-any-expr for HTMLFormatter.__init__ #28140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2019
Merged

TYPING: --disallow-any-expr for HTMLFormatter.__init__ #28140

merged 2 commits into from
Aug 26, 2019

Conversation

simonjayhawkins
Copy link
Member 

pandas\io\formats\html.py:44: error: Expression type contains "Any" (has type "Union[str, List[Any], Tuple[Any, ...], None]")
pandas\io\formats\html.py:49: error: Expression type contains "Any" (has type "Dict[str, Any]")
pandas\io\formats\html.py:49: error: Expression has type "Any"
pandas\io\formats\html.py:50: error: Expression type contains "Any" (has type "Dict[str, Any]")
pandas\io\formats\html.py:50: error: Expression has type "Any"
pandas\io\formats\html.py:54: error: Expression type contains "Any" (has type "Union[int, Any]")

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Aug 25, 2019
WillAyd
WillAyd approved these changes Aug 25, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd added this to the 1.0 milestone Aug 25, 2019
@WillAyd
Copy link
Member

WillAyd commented Aug 25, 2019

Maybe wait a day or two to see if any other devs would like to comment. Otherwise merge away

@simonjayhawkins
Copy link
Member Author

can wait. it is gradual typing! very gradual.

@WillAyd WillAyd merged commit ddfc9a2 into pandas-dev:master Aug 26, 2019
@WillAyd
Copy link
Member

WillAyd commented Aug 26, 2019

Thanks @simonjayhawkins

@simonjayhawkins simonjayhawkins deleted the HTMLFormatter.__init__ branch August 27, 2019 09:28
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@simonjayhawkins @proost
TYPING: --disallow-any-expr for HTMLFormatter.__init__ (pandas-dev#2…
35f4b12 
…8140)
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@simonjayhawkins @proost
TYPING: --disallow-any-expr for HTMLFormatter.__init__ (pandas-dev#2…
0f4ffd0 
…8140)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@simonjayhawkins @WillAyd