Skip to content

REF/TST: Add more pytest idiom to resample/test_base.py #24324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins commented Dec 17, 2018

in this pass:

  • restructure fixtures in order to parametrize base class tests
  • remove test base class

@pep8speaks
Copy link

Hello @simonjayhawkins! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #24324 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24324   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files         162      162           
  Lines       51831    51831           
=======================================
  Hits        47833    47833           
  Misses       3998     3998
Flag Coverage Δ
#multiple 90.69% <ø> (ø) ⬆️
#single 43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3675c29...a6e205d. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #24324 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24324      +/-   ##
==========================================
- Coverage   92.28%   92.28%   -0.01%     
==========================================
  Files         162      162              
  Lines       51831    51831              
==========================================
- Hits        47833    47832       -1     
- Misses       3998     3999       +1
Flag Coverage Δ
#multiple 90.69% <ø> (ø) ⬆️
#single 43.01% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 87.48% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3675c29...4857ece. Read the comment docs.

@jreback jreback added Resample resample method Testing pandas testing functions or related to the test suite labels Dec 18, 2018
@jreback
Copy link
Contributor

jreback commented Dec 18, 2018

let me have a look locally

@simonjayhawkins
Copy link
Member Author

i'm not happy with the restructuring of the fixtures. trying a different approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resample resample method Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants