-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
Closed
Labels
CleanResampleresample methodresample methodTestingpandas testing functions or related to the test suitepandas testing functions or related to the test suite
Description
As discussed in #16153 (comment), test_resample.py grew sufficiently large (currently ~ 2.7 k sloc), so splitting it up should make it more understandable.
Proposal to split along the existing classes:
tests/resample (sub-dir)
|- common.py
|- test_resample_api.py
|- base.py
|- test_datetime.py
|- test_period.py
|- test_timedelta.py
|- test_resample_grouper.py
|- test_time_grouper.py
Moreover, readability of some test cases could be improved by using pytest features:
- Convert nested for loops and "quasi-parametrized" tests (multiple test methods calling the same test logic with different parameters) to make use of @pytest.mark.parametrize decorator
- Use pytest fixtures where appropriate
Metadata
Metadata
Assignees
Labels
CleanResampleresample methodresample methodTestingpandas testing functions or related to the test suitepandas testing functions or related to the test suite