-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
DOC: update the pandas.DateTimeArrayMixin.is_month_start docstring #23051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: update the pandas.DateTimeArrayMixin.is_month_start docstring #23051
Conversation
Hello @CalmDownKarm! Thanks for updating the PR.
Comment last updated on October 11, 2018 at 07:18 Hours UTC |
Codecov Report
@@ Coverage Diff @@
## master #23051 +/- ##
==========================================
+ Coverage 92.19% 92.22% +0.03%
==========================================
Files 169 169
Lines 50954 51259 +305
==========================================
+ Hits 46975 47275 +300
- Misses 3979 3984 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are few formatting problems. There are two things you should do:
- Validate the docstring for formatting errors:
./scripts/validate_docstrings.py pandas.DateTimeArrayMixin.is_month_start
- Generate the html and see if it renders correctly:
./doc/make.py html --single=pandas.DateTimeArrayMixin.is_month_start
@datapythonista I made the changes you asked for, but both commands you asked me to run failed - AttributeError: module 'pandas' has no attribute 'DateTimeArrayMixin' probably a broken setup on my end? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command to run is ./scripts/validate_docstrings.py pandas.core.arrays.datetimes.DateTimeArrayMising
.
Got the full path to the class from the PR title, but seems like it's been shortened there.
is the validation script happy now? |
seems like there are whitespaces at the end of some lines in your code (check travis), can you remove them and validate pep8 |
@datapythonista fixed flake8 and validation script works now, but I'm unable to generate the html. python scripts/validate_docstrings.py pandas.core.arrays.datetimes.DatetimeArrayMixin.is_month_start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I didn't realize before, but probably it makes sense to have a common template for is_month_start
and is_month_end
, but we can take care of that in a separate PR.
@jbrockmendel do you want to take a look and merge if you're happy
Merge branch 'master' of github.com:pandas-dev/pandas into datetimes_docstring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Thanks @CalmDownKarm ! |
git diff upstream/master -u -- "*.py" | flake8 --diff
should close PR DOC: update the pandas.Series.dt.is_month_start docstring #20146