-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
DOC: Added Examples for Series max #23298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @vadakattu! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #23298 +/- ##
==========================================
+ Coverage 92.22% 92.23% +<.01%
==========================================
Files 169 169
Lines 50897 50925 +28
==========================================
+ Hits 46940 46969 +29
+ Misses 3957 3956 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Looks pretty good save one typo
Small request. +1 to merge once that's fixed. |
Updated from_arrays to from_product as suggested by @datapythonista on #23279 |
Thanks @vadakattu ! |
git diff upstream/master -u -- "*.py" | flake8 --diff