Skip to content

DOC: Added Examples for Series max #23298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 25, 2018
Merged

Conversation

vadakattu
Copy link
Contributor

@vadakattu vadakattu commented Oct 23, 2018

  • tests passed locally (to the same extent as master)
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@pep8speaks
Copy link

Hello @vadakattu! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Oct 23, 2018

Codecov Report

Merging #23298 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23298      +/-   ##
==========================================
+ Coverage   92.22%   92.23%   +<.01%     
==========================================
  Files         169      169              
  Lines       50897    50925      +28     
==========================================
+ Hits        46940    46969      +29     
+ Misses       3957     3956       -1
Flag Coverage Δ
#multiple 90.65% <100%> (ø) ⬆️
#single 42.28% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 96.79% <100%> (-0.05%) ⬇️
pandas/core/internals/blocks.py 94.02% <0%> (-0.06%) ⬇️
pandas/core/indexes/multi.py 95.46% <0%> (ø) ⬆️
pandas/core/indexes/interval.py 94.65% <0%> (+0.01%) ⬆️
pandas/core/arrays/categorical.py 95.56% <0%> (+0.03%) ⬆️
pandas/core/arrays/datetimes.py 97.45% <0%> (+0.05%) ⬆️
pandas/core/arrays/interval.py 93.02% <0%> (+0.2%) ⬆️
pandas/util/testing.py 86.73% <0%> (+0.23%) ⬆️
pandas/core/arrays/integer.py 95.48% <0%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0c91e...49b6330. Read the comment docs.

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks pretty good save one typo

@WillAyd WillAyd added the Docs label Oct 25, 2018
@TomAugspurger
Copy link
Contributor

Small request. +1 to merge once that's fixed.

@vadakattu
Copy link
Contributor Author

Updated from_arrays to from_product as suggested by @datapythonista on #23279

@WillAyd WillAyd merged commit c76173b into pandas-dev:master Oct 25, 2018
@WillAyd
Copy link
Member

WillAyd commented Oct 25, 2018

Thanks @vadakattu !

@vadakattu vadakattu deleted the series-max branch October 26, 2018 09:47
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants