Skip to content

CircleCI -> Azure #22992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Oct 26, 2018
Merged

CircleCI -> Azure #22992

merged 16 commits into from
Oct 26, 2018

Conversation

TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger commented Oct 4, 2018

Closes #22396
closes #22763

cc @jreback @h-vetinari @jorisvandenbossche @WillAyd

The main thing we lose is redundancy on the sql tests. Those are down to just travis.

However, if you wish to run the test suite on a branch prior to submitting the pull request,
then the continuous integration services need to be hooked to your GitHub repository. Instructions are here
for `Travis-CI <http://about.travis-ci.org/docs/user/getting-started/>`__,
`Appveyor <https://www.appveyor.com/docs/>`__ , and `CircleCI <https://circleci.com/>`__.
for `Travis-CI <http://about.travis-ci.org/docs/user/getting-started/>`__.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nitpick: http --> https

@codecov
Copy link

codecov bot commented Oct 4, 2018

Codecov Report

Merging #22992 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22992   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files         169      169           
  Lines       51259    51259           
=======================================
  Hits        47275    47275           
  Misses       3984     3984
Flag Coverage Δ
#multiple 90.66% <ø> (ø) ⬆️
#single 42.23% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd16b91...73c2413. Read the comment docs.

@TomAugspurger
Copy link
Contributor Author

To summarize the changes:

Adds 3 new azure builds

  1. 2.7-compat
  2. 3.6-locale
  3. 3.6-local-slow

That puts us up to 6 azure builds.

The 3.5 build is dropped. I think that's fine for now.

The locale stuff isn't working yet. Still debugging.

@datapythonista datapythonista added the CI Continuous Integration label Oct 4, 2018
@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Oct 4, 2018

OK I think the locale setting took effect. If you look at the summary in https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=656&view=ms.vss-test-web.test-result-details and search for a locale-related test, e.g. test_guess_datetime_format_with_locale_specific_formats, you'll see the skip message is Specific locale is set zh_CN.

I manually cancelled the travis build FYI, just to not overload it, it didn't fail on it's own.

edit: actually, restarting the travis build since I did have to change script-single and script-multi. For whatever reason the linux-based azure workers were having trouble publishing results from /tmp/*.xml. We got an insufficient privileges error, so maybe there's another xml file in there we can't touch. The solution was to just output the junitxml to our directory.

@jreback
Copy link
Contributor

jreback commented Oct 6, 2018

would be ok leaving the 1 circle ci test

@jreback jreback added this to the 0.24.0 milestone Oct 6, 2018
- task: PublishTestResults@2
inputs:
testResultsFiles: 'test-data-*.xml'
testRunTitle: 'Linux'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GH wants a \n here

@jbrockmendel
Copy link
Member

Needs rebase.

If circleCI isn't completely removed, it might be nice to collect the relevant scripts in ci/circleci/

@TomAugspurger
Copy link
Contributor Author

Restored one circle job for the SQL redundancy.

I'd recommend that if circle is running behind, we feel free to ignore it for changes that aren't likely to affect the SQL behavior.

@TomAugspurger
Copy link
Contributor Author

This is passing.

I'm not thrilled about having to maintain the circleci scripts, but it's probably worth it for the SQL redundancy.

@jreback
Copy link
Contributor

jreback commented Oct 26, 2018

@TomAugspurger I think i merged something in contributing.rst so rebase and let's merge on green.

@TomAugspurger
Copy link
Contributor Author

Apparently, circleCI missed the web hook on my latest one. But it did pass in https://circleci.com/gh/pandas-dev/pandas/26751?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link, which only differed by the doc fixup, so merging.

@TomAugspurger TomAugspurger merged commit 88a57c9 into pandas-dev:master Oct 26, 2018
@TomAugspurger TomAugspurger deleted the drop-circle branch October 26, 2018 12:07
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Improve CircleCI CircleCI 2.0 followup
5 participants