BUG: Fix for issue #12553 #12557
Closed
BUG: Fix for issue #12553 #12557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks. See the contributing guide here Like to have tests! |
| @@ -2790,6 +2790,10 @@ def true_and_notnull(x, *args, **kwargs): | |||
| def nunique(self, dropna=True): | |||
| """ Returns number of unique elements in the group """ | |||
| ids, _, _ = self.grouper.group_info | |||
|
|
|||
| if len(ids) == 0: # bufix for 12553 | |||
| return Series([]) | |||
There was a problem hiding this comment.
This should just be self._constructor, so objects that inherit can keep their type
There was a problem hiding this comment.
Using self._constructor causes an error for me. And the already existing return returns a Series() anyway. I don't understand the reason to change this.
|
in the future, no need to open a NEW pull-request, just force push to the old one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12553