Skip to content

BUG: Fix for issue #12553 #12557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

BUG: Fix for issue #12553 #12557

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6b722ba
Fix for issue #12553
thanasis2028 Mar 7, 2016
cf9e2d9
BUG: Fix for issue #12553
thanasis2028 Mar 7, 2016
748cb45
BUG: Fix for issue #12553
thanasis2028 Mar 7, 2016
802b3e1
BUG: Fix for issue #12553
thanasis2028 Mar 7, 2016
b024f28
BUG: Fix for issue #12553
thanasis2028 Mar 7, 2016
6a034e8
BUG: Fix for issue #12553
thanasis2028 Mar 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pandas/core/groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2790,6 +2790,10 @@ def true_and_notnull(x, *args, **kwargs):
def nunique(self, dropna=True):
""" Returns number of unique elements in the group """
ids, _, _ = self.grouper.group_info

if len(ids) == 0: # bugfix for 12553
return Series([])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should just be self._constructor, so objects that inherit can keep their type

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using self._constructor causes an error for me. And the already existing return returns a Series() anyway. I don't understand the reason to change this.


val = self.obj.get_values()

try:
Expand Down