[sled-agent] Don't bounce zones if their config changes only by an identical image_source
#8514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunshowers
approved these changes
Jul 3, 2025
|
Testing this on berlin looks good. Setup:
I derived a blueprint and changed the image source for every zone on one sled: All the zones except Making this new blueprint the target, sled-agent logs show the expected behavior; most zones had their configs updated in place, and the pantry zone was shut down and restarted: Confirmed by checking zone uptimes; the pantry zone had just restarted, and all other zones had uptimes back to when they originally started. A final confirmation: inventory shows that all the zones (even the non-bounced ones) are running from the requested artifacts: |
sunshowers
added a commit
to oxidecomputer/tufaceous
that referenced
this pull request
Jul 3, 2025
…file name (#33) In oxidecomputer/omicron#8514 we found that the artifact and file names don't actually match all the time. With this change, both the artifact and the file name will have to be specified. oxidecomputer/omicron#8510 is the issue that tracks cleaning this up.
sunshowers
added a commit
that referenced
this pull request
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, any change to the
OmicronZoneConfigof an already-running zone resulted in that zone being shut down and restarted. With this PR, we allow a single kind of change that does not restart the zone. If theimage_sourceswaps fromInstallDatasettoArtifact { hash }(or vice versa) and the hash of this zone in the install dataset exactly matches theArtifact { hash }, we don't need to do anything: we're already running the exact zone as desired, just started from a different place.Fixes #8463.
Makes #8510 slightly worse; yet another
ZoneKind::make_a_string()method. (This one is at least guaranteed-by-test to be an extension of an existing one. I don't feel a lot better about that though.)I'll test this on a racklette before merging; will put notes below once I do. But I think this is contained enough that it can be reviewed before that's done.