-
Notifications
You must be signed in to change notification settings - Fork 54
Open
Description
ZoneKind
currently has five different methods converting &self
to &'static str
, each of which is slightly different and is used in different contexts. This is confusing at best. Some examples of differences:
zone_prefix
uses underscores. These strings are used by sled-agent both to name zones and to find the{zone_prefix}.tar.gz
filenames in the install dataset.service_prefix
is almost the same, except crucible pantry iscrucible/pantry
instead ofcrucible_pantry
(presumably due to SMF namespace organization?)name_prefix
iszone_prefix
with all the underscores swapped to dashesreport_str
iszone_prefix
except it has separateboundary_ntp
andinternal_ntp
values, instead of usingntp
for bothartifact_name
matches theArtifactId::name
values from the unpacked composite control plane artifact in a TUF repo. These come from theoxide.json
'spkg
value inside each zone's tarball, and are an eclectic bunch that don't map neatly to the other methods (some use underscores, some use dashes, and some append a-zone
suffix)
Can we collapse some of these (with work to make the users of them use more consistent names)?
Metadata
Metadata
Assignees
Labels
No labels