Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Nov 19, 2025

Adds Resolver::find_tsconfig.

    /// Finds the `tsconfig` to which this `path` belongs.
    ///
    /// Algorithm:
    ///
    /// 1. Search for `tsconfig.json` in ancestor directories.
    /// 2. If the path is not included in this `tsconfig.json` through the `files`, `include`, or `exclude` fields:
    ///    2.1. Search through project references until a referenced `tsconfig` includes this file.
    ///    2.2. If none of the references include this path, return the `tsconfig.json` found in step 1.
    ///
    /// # Errors
    ///
    /// * Returns an error if the tsconfig is invalid, including any extended or referenced tsconfigs.
  • tracing
  • test windows
  • add benchmark
  • add cache

@graphite-app
Copy link

graphite-app bot commented Nov 19, 2025

How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 97.16312% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.14%. Comparing base (8ef6c6d) to head (feafed8).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/tsconfig.rs 97.67% 2 Missing ⚠️
src/tsconfig_resolver.rs 96.29% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
+ Coverage   94.00%   94.14%   +0.13%     
==========================================
  Files          17       17              
  Lines        2987     3092     +105     
==========================================
+ Hits         2808     2911     +103     
- Misses        179      181       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 19, 2025

CodSpeed Performance Report

Merging #854 will improve performances by 3.2%

Comparing 11-18-feat_port_tsconfck (feafed8) with main (3d70607)1

Summary

⚡ 1 improvement
✅ 10 untouched
🆕 1 new
⏩ 5 skipped2

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 resolver_memory[find tsconfig] N/A 15.6 µs N/A
resolver_memory[multi-thread] 484.2 µs 469.2 µs +3.2%

Footnotes

  1. No successful run was found on main (feafed8) during the generation of this report, so 3d70607 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Boshen Boshen force-pushed the 11-18-feat_port_tsconfck branch 10 times, most recently from 367c6e8 to a0ff198 Compare November 22, 2025 08:59
@Boshen Boshen requested a review from shulaoda November 22, 2025 09:06
@Boshen Boshen marked this pull request as ready for review November 22, 2025 14:48
Copy link
Member Author

Boshen commented Nov 22, 2025


How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Boshen Boshen force-pushed the 11-18-feat_port_tsconfck branch from a0ff198 to 62c4497 Compare November 23, 2025 07:07
@Boshen Boshen added the merge label Nov 24, 2025
Copy link
Member Author

Boshen commented Nov 24, 2025

Merge activity

  • Nov 24, 5:15 AM UTC: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 24, 5:15 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Nov 24, 5:15 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Nov 24, 5:15 AM UTC: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 24, 5:20 AM UTC: Boshen added this pull request to the Graphite merge queue.
  • Nov 24, 5:23 AM UTC: Merged by the Graphite merge queue.

@Boshen Boshen force-pushed the 11-18-feat_port_tsconfck branch from 62c4497 to ceedb27 Compare November 24, 2025 05:16
Adds `Resolver::find_tsconfig`.

```
    /// Finds the `tsconfig` to which this `path` belongs.
    ///
    /// Algorithm:
    ///
    /// 1. Search for `tsconfig.json` in ancestor directories.
    /// 2. If the path is not included in this `tsconfig.json` through the `files`, `include`, or `exclude` fields:
    ///    2.1. Search through project references until a referenced `tsconfig` includes this file.
    ///    2.2. If none of the references include this path, return the `tsconfig.json` found in step 1.
    ///
    /// # Errors
    ///
    /// * Returns an error if the tsconfig is invalid, including any extended or referenced tsconfigs.
```

- [x] tracing
- [x] test windows
- [x] add benchmark
- [x] add cache
@graphite-app graphite-app bot force-pushed the 11-18-feat_port_tsconfck branch from ceedb27 to feafed8 Compare November 24, 2025 05:20
@graphite-app graphite-app bot merged commit feafed8 into main Nov 24, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 11-18-feat_port_tsconfck branch November 24, 2025 05:23
@graphite-app graphite-app bot removed the merge label Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants