-
-
Notifications
You must be signed in to change notification settings - Fork 35
feat: port tsconfck (find tsconfig files) #854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How to use the Graphite Merge QueueAdd the label merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #854 +/- ##
==========================================
+ Coverage 94.00% 94.14% +0.13%
==========================================
Files 17 17
Lines 2987 3092 +105
==========================================
+ Hits 2808 2911 +103
- Misses 179 181 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #854 will improve performances by 3.2%Comparing Summary
Benchmarks breakdown
Footnotes
|
367c6e8 to
a0ff198
Compare
How to use the Graphite Merge QueueAdd the label merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
a0ff198 to
62c4497
Compare
Merge activity
|
62c4497 to
ceedb27
Compare
Adds `Resolver::find_tsconfig`.
```
/// Finds the `tsconfig` to which this `path` belongs.
///
/// Algorithm:
///
/// 1. Search for `tsconfig.json` in ancestor directories.
/// 2. If the path is not included in this `tsconfig.json` through the `files`, `include`, or `exclude` fields:
/// 2.1. Search through project references until a referenced `tsconfig` includes this file.
/// 2.2. If none of the references include this path, return the `tsconfig.json` found in step 1.
///
/// # Errors
///
/// * Returns an error if the tsconfig is invalid, including any extended or referenced tsconfigs.
```
- [x] tracing
- [x] test windows
- [x] add benchmark
- [x] add cache
ceedb27 to
feafed8
Compare

Adds
Resolver::find_tsconfig.