Skip to content

Conversation

@airween
Copy link
Member

@airween airween commented Jun 10, 2025

what

This PR sets the correct version string in MSI installer file.

why

There is a user report about the wrong version string.

references

See #3399 for the report.

@airween airween requested review from fzipi and theseion June 10, 2025 08:57
Copy link
Contributor

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be cleaned up. There is a lot of commented stuff (e.g. old crs versions). Also, do you know which pcre version is used by default in the windows build? It should be using the newer version also, right?

Co-authored-by: Felipe Zipitría <[email protected]>
@sonarqubecloud
Copy link

@airween
Copy link
Member Author

airween commented Jun 10, 2025

This file should be cleaned up.

Yes, definitely, it should.

There is a lot of commented stuff (e.g. old crs versions). Also, do you know which pcre version is used by default in the windows build? It should be using the newer version also, right?

I have no idea. Unfortunately, I don't have any Windows and can't check the build flow. I know this is a big problem, because there is another Windows related issue (#3397). But for that (and for this too) we need not just a Windows, but an IIS too.

@airween airween requested a review from fzipi June 10, 2025 14:14
@airween airween requested review from theseion and removed request for theseion June 10, 2025 14:54
@airween airween merged commit 348005a into owasp-modsecurity:v2/master Jun 11, 2025
82 checks passed
@airween airween added the 2.x Related to ModSecurity version 2.x label Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.x Related to ModSecurity version 2.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants