Outdated product version in the MSI installer

[skvoboo-gh]

Describe the bug

The Product Version property in the MSI Installer is 2.9.7.

To Reproduce

installer.wxs

Expected behavior

The Product Version property in the MSI Installer must match the ModSecurity version (the latest released v2 version is 2.9.10).
The MSI installer must be published in the ModSecurity release assets.

Server (please complete the following information):

• ModSecurity version (and connector): 2.9.10 MSI installer
• WebServer: IIS
• OS (and distro): Windows

[airween]

Hi @skvoboo-gh,

thanks for reporting this. I sent a PR to fix this issue, and added the task into our release procedure.

Unfortunately we can update the version string only in the next release. Sorry for the inconvenience.

[skvoboo-gh]

Please note that you will need to bump the Product Version in MSI Installer every time you upgrade ModSecurity version. Therefore, in the next release, you should bump the Product Version in MSI Installer again.

Don't forget to publish the MSI installer (ModSecurityIIS_2.x.y-64b-64.msi) in the ModSecurity next release assets please.

[airween]

Please note that you will need to bump the Product Version in MSI Installer every time you upgrade ModSecurity version. Therefore, in the next release, you should bump the Product Version in MSI Installer again.

yes, we do. As I wrote above, I added this step into our release procedure documentation.

Don't forget to publish the MSI installer (ModSecurityIIS_2.x.y-64b-64.msi) in the ModSecurity next release assets please.

Well, I can't promise this. I don't have Windows or IIS. Furthermore, I'm not familiar in IIS, so I don't know what are the expectations. I'm not a fan of pre-packaged assets, because there are many options which use must decide in compilation time. And this is what I can't decide...

[airween]

@skvoboo-gh do you have any other question? If not, could we close this issue?

[skvoboo-gh]

I have no other questions regarding this issue.
But I'll create another issue, because no one but you will be able to build ModSecurity 2.x for Windows. The task is impossible (requiring precompiled Apache in the same outdated Visual Studio is overkill).