Skip to content

✨ Fix e2e #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2024
Merged

✨ Fix e2e #843

merged 1 commit into from
May 10, 2024

Conversation

varshaprasad96
Copy link
Member

Description

Fixes e2e! go.mod needs to be updated to after operator-framework/rukpak#884 gets merged.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@varshaprasad96 varshaprasad96 requested a review from a team as a code owner May 10, 2024 07:38
@tmshort
Copy link
Contributor

tmshort commented May 10, 2024

Is this supposed to fix the e2e? It's still failing.
Also, the lint issues are new to this PR.

@varshaprasad96 varshaprasad96 force-pushed the fix/e2e branch 2 times, most recently from 7f6d23f to 7e9be69 Compare May 10, 2024 18:52
Signed-off-by: Varsha Prasad Narsing <[email protected]>
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (helm-poc@0d3aa8f). Click here to learn what that means.

Files Patch % Lines
...nternal/controllers/clusterextension_controller.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             helm-poc     #843   +/-   ##
===========================================
  Coverage            ?   64.90%           
===========================================
  Files               ?       20           
  Lines               ?     1607           
  Branches            ?        0           
===========================================
  Hits                ?     1043           
  Misses              ?      456           
  Partials            ?      108           
Flag Coverage Δ
e2e 36.77% <0.00%> (?)
unit 50.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmshort
Copy link
Contributor

tmshort commented May 10, 2024

e2e is passing!

Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2024
@tmshort tmshort merged commit 1eecf62 into operator-framework:helm-poc May 10, 2024
12 checks passed
@varshaprasad96 varshaprasad96 deleted the fix/e2e branch May 10, 2024 20:11
varshaprasad96 added a commit to varshaprasad96/operator-controller that referenced this pull request May 10, 2024
Signed-off-by: Varsha Prasad Narsing <[email protected]>
tmshort pushed a commit that referenced this pull request May 11, 2024
Signed-off-by: Varsha Prasad Narsing <[email protected]>
bentito pushed a commit that referenced this pull request May 14, 2024
Signed-off-by: Varsha Prasad Narsing <[email protected]>
bentito pushed a commit that referenced this pull request May 14, 2024
Signed-off-by: Varsha Prasad Narsing <[email protected]>
dtfranz pushed a commit that referenced this pull request May 23, 2024
Signed-off-by: Varsha Prasad Narsing <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request May 30, 2024
…s into the cluster (#846)

* Helm POC rebase-a-thon

* Unpack Image (#811)

Builds and loads the unpacker binary into the operator-controller image so we don't need to use the rukpak image.

Signed-off-by: dtfranz <[email protected]>

* ✨ OPRUN-3293 Fixes several unit tests - not cache ones  (#831)

* Fix, rm or skip BundleDeployment related tests

Signed-off-by: Brett Tofel <[email protected]>

* Address lint errors

Signed-off-by: Brett Tofel <[email protected]>

---------

Signed-off-by: Brett Tofel <[email protected]>

* Fix e2e (#843)

Signed-off-by: Varsha Prasad Narsing <[email protected]>

* Make goreleaser build unpack

Signed-off-by: Brett Tofel <[email protected]>

* Rm commented code

Signed-off-by: Brett Tofel <[email protected]>

* Rebase required changes

Signed-off-by: Brett Tofel <[email protected]>

* Cleanups (#854)

Signed-off-by: Varsha Prasad Narsing <[email protected]>

* Expand comments in Dockerfile

Signed-off-by: Brett Tofel <[email protected]>

* Address Reviews

Signed-off-by: Varsha Prasad Narsing <[email protected]>

* Back out packagerrors

It's agreed that this makes debugging and reasoning about log messages and runtime errors much harder.

Signed-off-by: Brett Tofel <[email protected]>

* Helm POC e2e fixes (#870)

Fixes the e2e tests in helm-poc branch and restores feature-gate switching.

Signed-off-by: dtfranz <[email protected]>

* Fix defer location (#883)

Fixes the defer location to make sure that all resources are cleaned up properly.

Signed-off-by: dtfranz <[email protected]>

* Remove BundleDeployments gathering from e2e's gatherArtifacts (#886)

When tests fail, gatherArtifacts is run to collect cluster state. This PR removes gathering of BundleDeployments since we don't use them anymore and it's generating additional misleading error messages.

Signed-off-by: dtfranz <[email protected]>

* Address reviews (#887)

Signed-off-by: Varsha Prasad Narsing <[email protected]>

* 🌱 Proposed way to unskip some tests (#874)

* Proposed way to unskip some tests

TestClusterExtensionChannelVersionExists mostly restored here

Signed-off-by: Brett Tofel <[email protected]>

* Refactors global variable names

Signed-off-by: Brett Tofel <[email protected]>

* Removes BundleDeployment related checking

In just one test, for now.

Signed-off-by: Brett Tofel <[email protected]>

* fix unit test - TestClusterExtensionChannelVersionExists

* Unskip all - failing tests (up|down)grade should err

Unskips all in clusterextension_controller_test.go

Signed-off-by: Brett Tofel <[email protected]>

* Unskip all clusterextension_registryv1_validation_test.go

Still failing tests (up|down)grade should err b/c we don't have an installedBundle to check against

Signed-off-by: Brett Tofel <[email protected]>

* debugging

Signed-off-by: Varsha Prasad Narsing <[email protected]>

* Fixes and additions pending & unpack path

Signed-off-by: Brett Tofel <[email protected]>

* Fix linter, remove debug logs and extraneous file

Signed-off-by: dtfranz <[email protected]>

* Fix e2e failure due to race condition

Signed-off-by: dtfranz <[email protected]>

---------

Signed-off-by: Brett Tofel <[email protected]>
Signed-off-by: Varsha Prasad Narsing <[email protected]>
Signed-off-by: dtfranz <[email protected]>
Co-authored-by: Varsha Prasad Narsing <[email protected]>
Co-authored-by: dtfranz <[email protected]>

* Revert goreleaser to use buildx

Signed-off-by: Brett Tofel <[email protected]>

* Revert all of goreleaser to use buildx

Signed-off-by: Brett Tofel <[email protected]>

* Revert errorf->printf & rm some logging in tests

Signed-off-by: Brett Tofel <[email protected]>

---------

Signed-off-by: dtfranz <[email protected]>
Signed-off-by: Brett Tofel <[email protected]>
Signed-off-by: Varsha Prasad Narsing <[email protected]>
Co-authored-by: Todd Short <[email protected]>
Co-authored-by: Daniel Franz <[email protected]>
Co-authored-by: Varsha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants