Skip to content

🌱 Fix defer location #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2024

Conversation

dtfranz
Copy link
Contributor

@dtfranz dtfranz commented May 21, 2024

Fixes the defer location to make sure that all resources are cleaned up properly.

Fixes the defer location to make sure that all resources are cleaned up properly.

Signed-off-by: dtfranz <[email protected]>
@dtfranz dtfranz requested a review from a team as a code owner May 21, 2024 20:39
@dtfranz dtfranz changed the title Fix defer location 🌱 Fix defer location May 21, 2024
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.38%. Comparing base (53577db) to head (3e0d95a).

Additional details and impacted files
@@            Coverage Diff            @@
##           helm-poc     #883   +/-   ##
=========================================
  Coverage     75.38%   75.38%           
=========================================
  Files            18       18           
  Lines          1170     1170           
=========================================
  Hits            882      882           
  Misses          208      208           
  Partials         80       80           
Flag Coverage Δ
e2e 56.06% <ø> (ø)
unit 50.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dtfranz dtfranz merged commit d44a62e into operator-framework:helm-poc May 21, 2024
11 of 12 checks passed
dtfranz added a commit that referenced this pull request May 23, 2024
Fixes the defer location to make sure that all resources are cleaned up properly.

Signed-off-by: dtfranz <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request May 30, 2024
…s into the cluster (#846)

* Helm POC rebase-a-thon

* Unpack Image (#811)

Builds and loads the unpacker binary into the operator-controller image so we don't need to use the rukpak image.

Signed-off-by: dtfranz <[email protected]>

* ✨ OPRUN-3293 Fixes several unit tests - not cache ones  (#831)

* Fix, rm or skip BundleDeployment related tests

Signed-off-by: Brett Tofel <[email protected]>

* Address lint errors

Signed-off-by: Brett Tofel <[email protected]>

---------

Signed-off-by: Brett Tofel <[email protected]>

* Fix e2e (#843)

Signed-off-by: Varsha Prasad Narsing <[email protected]>

* Make goreleaser build unpack

Signed-off-by: Brett Tofel <[email protected]>

* Rm commented code

Signed-off-by: Brett Tofel <[email protected]>

* Rebase required changes

Signed-off-by: Brett Tofel <[email protected]>

* Cleanups (#854)

Signed-off-by: Varsha Prasad Narsing <[email protected]>

* Expand comments in Dockerfile

Signed-off-by: Brett Tofel <[email protected]>

* Address Reviews

Signed-off-by: Varsha Prasad Narsing <[email protected]>

* Back out packagerrors

It's agreed that this makes debugging and reasoning about log messages and runtime errors much harder.

Signed-off-by: Brett Tofel <[email protected]>

* Helm POC e2e fixes (#870)

Fixes the e2e tests in helm-poc branch and restores feature-gate switching.

Signed-off-by: dtfranz <[email protected]>

* Fix defer location (#883)

Fixes the defer location to make sure that all resources are cleaned up properly.

Signed-off-by: dtfranz <[email protected]>

* Remove BundleDeployments gathering from e2e's gatherArtifacts (#886)

When tests fail, gatherArtifacts is run to collect cluster state. This PR removes gathering of BundleDeployments since we don't use them anymore and it's generating additional misleading error messages.

Signed-off-by: dtfranz <[email protected]>

* Address reviews (#887)

Signed-off-by: Varsha Prasad Narsing <[email protected]>

* 🌱 Proposed way to unskip some tests (#874)

* Proposed way to unskip some tests

TestClusterExtensionChannelVersionExists mostly restored here

Signed-off-by: Brett Tofel <[email protected]>

* Refactors global variable names

Signed-off-by: Brett Tofel <[email protected]>

* Removes BundleDeployment related checking

In just one test, for now.

Signed-off-by: Brett Tofel <[email protected]>

* fix unit test - TestClusterExtensionChannelVersionExists

* Unskip all - failing tests (up|down)grade should err

Unskips all in clusterextension_controller_test.go

Signed-off-by: Brett Tofel <[email protected]>

* Unskip all clusterextension_registryv1_validation_test.go

Still failing tests (up|down)grade should err b/c we don't have an installedBundle to check against

Signed-off-by: Brett Tofel <[email protected]>

* debugging

Signed-off-by: Varsha Prasad Narsing <[email protected]>

* Fixes and additions pending & unpack path

Signed-off-by: Brett Tofel <[email protected]>

* Fix linter, remove debug logs and extraneous file

Signed-off-by: dtfranz <[email protected]>

* Fix e2e failure due to race condition

Signed-off-by: dtfranz <[email protected]>

---------

Signed-off-by: Brett Tofel <[email protected]>
Signed-off-by: Varsha Prasad Narsing <[email protected]>
Signed-off-by: dtfranz <[email protected]>
Co-authored-by: Varsha Prasad Narsing <[email protected]>
Co-authored-by: dtfranz <[email protected]>

* Revert goreleaser to use buildx

Signed-off-by: Brett Tofel <[email protected]>

* Revert all of goreleaser to use buildx

Signed-off-by: Brett Tofel <[email protected]>

* Revert errorf->printf & rm some logging in tests

Signed-off-by: Brett Tofel <[email protected]>

---------

Signed-off-by: dtfranz <[email protected]>
Signed-off-by: Brett Tofel <[email protected]>
Signed-off-by: Varsha Prasad Narsing <[email protected]>
Co-authored-by: Todd Short <[email protected]>
Co-authored-by: Daniel Franz <[email protected]>
Co-authored-by: Varsha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants