🌱 Fix defer location #883
Merged
🌱 Fix defer location #883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the defer location to make sure that all resources are cleaned up properly. Signed-off-by: dtfranz <[email protected]>
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## helm-poc #883 +/- ##
=========================================
Coverage 75.38% 75.38%
=========================================
Files 18 18
Lines 1170 1170
=========================================
Hits 882 882
Misses 208 208
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dtfranz
added a commit
that referenced
this pull request
May 23, 2024
Fixes the defer location to make sure that all resources are cleaned up properly. Signed-off-by: dtfranz <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 30, 2024
…s into the cluster (#846) * Helm POC rebase-a-thon * Unpack Image (#811) Builds and loads the unpacker binary into the operator-controller image so we don't need to use the rukpak image. Signed-off-by: dtfranz <[email protected]> * ✨ OPRUN-3293 Fixes several unit tests - not cache ones (#831) * Fix, rm or skip BundleDeployment related tests Signed-off-by: Brett Tofel <[email protected]> * Address lint errors Signed-off-by: Brett Tofel <[email protected]> --------- Signed-off-by: Brett Tofel <[email protected]> * Fix e2e (#843) Signed-off-by: Varsha Prasad Narsing <[email protected]> * Make goreleaser build unpack Signed-off-by: Brett Tofel <[email protected]> * Rm commented code Signed-off-by: Brett Tofel <[email protected]> * Rebase required changes Signed-off-by: Brett Tofel <[email protected]> * Cleanups (#854) Signed-off-by: Varsha Prasad Narsing <[email protected]> * Expand comments in Dockerfile Signed-off-by: Brett Tofel <[email protected]> * Address Reviews Signed-off-by: Varsha Prasad Narsing <[email protected]> * Back out packagerrors It's agreed that this makes debugging and reasoning about log messages and runtime errors much harder. Signed-off-by: Brett Tofel <[email protected]> * Helm POC e2e fixes (#870) Fixes the e2e tests in helm-poc branch and restores feature-gate switching. Signed-off-by: dtfranz <[email protected]> * Fix defer location (#883) Fixes the defer location to make sure that all resources are cleaned up properly. Signed-off-by: dtfranz <[email protected]> * Remove BundleDeployments gathering from e2e's gatherArtifacts (#886) When tests fail, gatherArtifacts is run to collect cluster state. This PR removes gathering of BundleDeployments since we don't use them anymore and it's generating additional misleading error messages. Signed-off-by: dtfranz <[email protected]> * Address reviews (#887) Signed-off-by: Varsha Prasad Narsing <[email protected]> * 🌱 Proposed way to unskip some tests (#874) * Proposed way to unskip some tests TestClusterExtensionChannelVersionExists mostly restored here Signed-off-by: Brett Tofel <[email protected]> * Refactors global variable names Signed-off-by: Brett Tofel <[email protected]> * Removes BundleDeployment related checking In just one test, for now. Signed-off-by: Brett Tofel <[email protected]> * fix unit test - TestClusterExtensionChannelVersionExists * Unskip all - failing tests (up|down)grade should err Unskips all in clusterextension_controller_test.go Signed-off-by: Brett Tofel <[email protected]> * Unskip all clusterextension_registryv1_validation_test.go Still failing tests (up|down)grade should err b/c we don't have an installedBundle to check against Signed-off-by: Brett Tofel <[email protected]> * debugging Signed-off-by: Varsha Prasad Narsing <[email protected]> * Fixes and additions pending & unpack path Signed-off-by: Brett Tofel <[email protected]> * Fix linter, remove debug logs and extraneous file Signed-off-by: dtfranz <[email protected]> * Fix e2e failure due to race condition Signed-off-by: dtfranz <[email protected]> --------- Signed-off-by: Brett Tofel <[email protected]> Signed-off-by: Varsha Prasad Narsing <[email protected]> Signed-off-by: dtfranz <[email protected]> Co-authored-by: Varsha Prasad Narsing <[email protected]> Co-authored-by: dtfranz <[email protected]> * Revert goreleaser to use buildx Signed-off-by: Brett Tofel <[email protected]> * Revert all of goreleaser to use buildx Signed-off-by: Brett Tofel <[email protected]> * Revert errorf->printf & rm some logging in tests Signed-off-by: Brett Tofel <[email protected]> --------- Signed-off-by: dtfranz <[email protected]> Signed-off-by: Brett Tofel <[email protected]> Signed-off-by: Varsha Prasad Narsing <[email protected]> Co-authored-by: Todd Short <[email protected]> Co-authored-by: Daniel Franz <[email protected]> Co-authored-by: Varsha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the defer location to make sure that all resources are cleaned up properly.