Skip to content

Conversation

LalatenduMohanty
Copy link
Member

Fixes #1295

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@LalatenduMohanty LalatenduMohanty requested a review from a team as a code owner September 24, 2024 14:21
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 24, 2024
Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 0ace0dd
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66f2cbc1fd3d1a0007e0a531
😎 Deploy Preview https://deploy-preview-1304--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LalatenduMohanty LalatenduMohanty force-pushed the remove_healthy_status_cond branch from 6574838 to 0ace0dd Compare September 24, 2024 14:25
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.44%. Comparing base (bc962f1) to head (0ace0dd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1304      +/-   ##
==========================================
- Coverage   76.60%   76.44%   -0.16%     
==========================================
  Files          40       40              
  Lines        2406     2390      -16     
==========================================
- Hits         1843     1827      -16     
  Misses        395      395              
  Partials      168      168              
Flag Coverage Δ
e2e 58.45% <ø> (+0.30%) ⬆️
unit 52.80% <ø> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LalatenduMohanty LalatenduMohanty changed the title [WIP] Removing healthy status condition [WIP] ⚠️ Removing healthy status condition Sep 24, 2024
@LalatenduMohanty LalatenduMohanty changed the title [WIP] ⚠️ Removing healthy status condition ⚠️ Removing healthy status condition Sep 24, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 24, 2024
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2024
@tmshort tmshort mentioned this pull request Sep 24, 2024
4 tasks
@tmshort tmshort added this pull request to the merge queue Sep 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 24, 2024
@tmshort tmshort added this pull request to the merge queue Sep 24, 2024
Merged via the queue into operator-framework:main with commit eea61cf Sep 24, 2024
18 of 20 checks passed
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1 API Review] Remove the Healthy status condition
2 participants