Skip to content

[v1 API Review] Remove the Healthy status condition #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #740
everettraven opened this issue Sep 20, 2024 · 1 comment · Fixed by #1304
Closed
Tracked by #740

[v1 API Review] Remove the Healthy status condition #1295

everettraven opened this issue Sep 20, 2024 · 1 comment · Fixed by #1304
Assignees
Labels
epic/v1-api v1.0 Issues related to the initial stable release of OLMv1

Comments

@everettraven
Copy link
Contributor

everettraven commented Sep 20, 2024

As part of #1292 , informer establishment errors will be presented to a user via the Progressing status condition. Once #1292 is implemented, the Healthy condition will no longer be used and all code associated with it will need to be removed.

For more information, see the RFC

@everettraven everettraven added v1.0 Issues related to the initial stable release of OLMv1 epic/v1-api labels Sep 20, 2024
@LalatenduMohanty LalatenduMohanty self-assigned this Sep 23, 2024
@LalatenduMohanty
Copy link
Member

@everettraven As discussed we will remove the status conditions first and then add progressing status condition. In that case just removing the code block https://github.com/operator-framework/operator-controller/blob/main/internal/controllers/clusterextension_controller.go#L322-L326 without adding anything in its place feels not right.

apimeta.SetStatusCondition(&ext.Status.Conditions, metav1.Condition{
			Type:               ocv1alpha1.TypeHealthy,
			Reason:             ocv1alpha1.ReasonUnverifiable,
			Status:             metav1.ConditionUnknown,
			Message:            err.Error(),
			ObservedGeneration: ext.Generation,
		})

LalatenduMohanty added a commit to LalatenduMohanty/operator-controller that referenced this issue Sep 24, 2024
LalatenduMohanty added a commit to LalatenduMohanty/operator-controller that referenced this issue Sep 24, 2024
github-merge-queue bot pushed a commit that referenced this issue Sep 24, 2024
Fixes #1295

Signed-off-by: Lalatendu Mohanty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic/v1-api v1.0 Issues related to the initial stable release of OLMv1
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants