-
Notifications
You must be signed in to change notification settings - Fork 218
fix: do not change namespaces if they were manually set #1734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not getting this, KubernetesDependentResourceConfig
should no be namespace changeable, why is that? namespace changeable should only apply for informers
This was needed at some point: https://github.com/java-operator-sdk/java-operator-sdk/pull/1554/files#diff-6fca1d1644dadba71e06623b843eff387374279a921562c0ea6532d98b53d820R181-R193 |
Ok, somehow I have I feeling its a bit too complex with these configs. |
Might be a different PR though, so will accept this one, and it's up to you. |
5aefd80
to
4af2cc5
Compare
fe820ca
to
55f5d0b
Compare
261b7c2
to
225c134
Compare
0069a01
to
552050a
Compare
Kudos, SonarCloud Quality Gate passed! |
Also remove unneeded implementation of NamespaceChangeable
Also remove unneeded implementation of NamespaceChangeable
Also remove unneeded implementation of NamespaceChangeable
Also remove unneeded implementation of NamespaceChangeable
Also remove unneeded implementation of NamespaceChangeable
Also remove unneeded implementation of NamespaceChangeable
Also remove unneeded implementation of NamespaceChangeable
Also remove unneeded implementation of NamespaceChangeable
No description provided.