fix: do not change namespaces if they were manually set (#1734)

Also remove unneeded implementation of NamespaceChangeable

Author: metacosm

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResourceConfig.java

@@ -2,7 +2,6 @@
 
 import java.util.Set;
 
-import io.javaoperatorsdk.operator.api.config.NamespaceChangeable;
 import io.javaoperatorsdk.operator.api.reconciler.Constants;
 import io.javaoperatorsdk.operator.api.reconciler.ResourceDiscriminator;
 import io.javaoperatorsdk.operator.processing.event.source.filter.GenericFilter;
@@ -12,7 +11,7 @@
 
 import static io.javaoperatorsdk.operator.api.reconciler.Constants.NO_VALUE_SET;
 
-public class KubernetesDependentResourceConfig<R> implements NamespaceChangeable {
+public class KubernetesDependentResourceConfig<R> {
 
   private Set<String> namespaces = Constants.SAME_AS_CONTROLLER_NAMESPACES_SET;
   private String labelSelector = NO_VALUE_SET;
@@ -89,16 +88,9 @@ public ResourceDiscriminator getResourceDiscriminator() {
     return resourceDiscriminator;
   }
 
-  @Override
-  public void changeNamespaces(Set<String> namespaces) {
-    if (!wereNamespacesConfigured()) {
-      this.namespacesWereConfigured = true;
-      setNamespaces(namespaces);
-    }
-  }
-
+  @SuppressWarnings("unused")
   protected void setNamespaces(Set<String> namespaces) {
-    if (namespaces != null && !namespaces.isEmpty()) {
+    if (!wereNamespacesConfigured() && namespaces != null && !namespaces.isEmpty()) {
       this.namespaces = namespaces;
     }
   }