Skip to content

Support graceful stop with configurable timeout #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gyfora opened this issue Jan 23, 2023 · 5 comments · Fixed by #1735
Closed

Support graceful stop with configurable timeout #1730

gyfora opened this issue Jan 23, 2023 · 5 comments · Fixed by #1735
Assignees
Labels
feature kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@gyfora
Copy link

gyfora commented Jan 23, 2023

Feature Request

It would be great if we could support a graceful stop/shutdown operation that would wait for currently in progress reconciliation for a user configured timout period.

During the shutdown we should not trigger new reconciliation.

This would also allow a smoother operation during upgrades, or other pod restarts.

@csviri csviri added this to the 4.3 milestone Jan 23, 2023
@csviri
Copy link
Collaborator

csviri commented Jan 23, 2023

Ahh, yes, but for this I think the shutdown hook is needed. That is deprecated. Probably it should not be then.

@csviri
Copy link
Collaborator

csviri commented Jan 23, 2023

Also would be good to have an integration test for this.

@csviri csviri self-assigned this Jan 23, 2023
@metacosm
Copy link
Collaborator

You need a shutdown hook to be able to handle graceful shutdowns, though, don't you?

@csviri
Copy link
Collaborator

csviri commented Jan 23, 2023

Yes, that is what I meant.

@csviri csviri linked a pull request Jan 25, 2023 that will close this issue
@csviri csviri added feature kind/feature Categorizes issue or PR as related to a new feature. labels Jan 25, 2023
@csviri csviri closed this as completed Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants