feat: graceful shutdown #1735
feat: graceful shutdown #1735
Conversation
|
This might deserve also an end to end test, to showcase, how SIGTERM and SIGKILL works in pods. WDYT @metacosm ? |
| // this is needed for the case when controller stopped, but there is a graceful shutdown | ||
| // timeout. that should finish the currently executing reconciliations but not the ones | ||
| // which where submitted but not started yet | ||
| log.debug("Event processor not running skipping resource processing: {}", resourceID); |
There was a problem hiding this comment.
Isn't this missing a return statement here?
There was a problem hiding this comment.
yes, wonder how the test passed, will check
There was a problem hiding this comment.
fixed the unit test, was not trivial, wonder if we should refactor this in the future.
| @@ -121,6 +121,7 @@ public HasMetadata clone(HasMetadata object) { | |||
| * | |||
| * @return the number of seconds to wait before terminating reconciliation threads | |||
| */ | |||
| @Deprecated(forRemoval = true) | |||
There was a problem hiding this comment.
This also needs an associated @deprecated tag in the javadoc…
csviri
force-pushed
the
graceful-shutdown
branch
from
ef81c22 to
1c62152
Compare
| @@ -121,8 +121,12 @@ public HasMetadata clone(HasMetadata object) { | |||
| * Retrieves the number of seconds the SDK waits for reconciliation threads to terminate before | |||
| * shutting down. | |||
| * | |||
| * @deprecated use {@link io.javaoperatorsdk.operator.Operator#stop(Duration)} instead. Where the | |||
There was a problem hiding this comment.
question: why not keep this? It could be useful to be able to configure the default timeout as previously…
There was a problem hiding this comment.
I would prefer to have a single way to configure this, and it is much simpler with the parameters. Keeping this, would be two way to do the same thing.
[skip ci]
[skip ci]
csviri
force-pushed
the
graceful-shutdown
branch
from
52ec2ce to
430b1af
Compare
|
Kudos, SonarCloud Quality Gate passed! |
No description provided.