feat: Default to Podman Socket #1242
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
adambkaplan
force-pushed
the
podman-socket-default
branch
from
e5bbf8d to
a65577c
Compare
Update s2i's defaults to inspect the host system for Podman sockets. Podman socket provides support for the Docker v1.40 API, which meets s2i's needs. The logic looks for the podman socket in the following order: 1. Rootless podman socket 2. Root podman socket 3. Docker socket If none are found, the default falls back to the docker socket. As before, the `--url` and `DOCKER_HOST` environment variables can override the container engine socket location. Signed-off-by: Adam Kaplan <[email protected]>
adambkaplan
force-pushed
the
podman-socket-default
branch
from
a65577c to
9e641cf
Compare
|
@adambkaplan: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@psrvere please take a look - this will let us (finally) remove the hard dependency on Docker! |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
2 participants
Update s2i's defaults to inspect the host system for Podman sockets. Podman socket provides support for the Docker v1.40 API, which meets s2i's needs. The logic looks for the podman socket in the following order:
If none are found, the default falls back to the docker socket. As before, the
--urlandDOCKER_HOSTenvironment variables can override the container engine socket location.Fixes #1163