Skip to content

NO-ISSUE: Remove bindata generation from build [reapply] #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2025
Merged

NO-ISSUE: Remove bindata generation from build [reapply] #448

merged 1 commit into from
Aug 18, 2025

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Aug 18, 2025

Reapply #438
Using go-bindata is causing problems with ART builds.

This removes the use of go-bindata from the builds.

This will subsequently require that users MANUALLY run the bindata target to refresh the bindata, or use the build-update target.

This is a quickfix to put out the fire.

@tmshort
UPSTREAM: <carry>: Remove bindata generation from build
6b41cbb 
Using go-bindata is causing problems with ART builds.

This removes the use of go-bindata from the builds.

This will subsequently require that users MANUALLY run
the `bindata` target to refresh the bindata, or use
the `build-update` target.

This is a quickfix to put out the fire.

Signed-off-by: Todd Short <[email protected]>
@openshift-ci-robot
Copy link

@tmshort: This pull request explicitly references no jira issue.

In response to this:

Reapply #438
Using go-bindata is causing problems with ART builds.

This removes the use of go-bindata from the builds.

This will subsequently require that users MANUALLY run the bindata target to refresh the bindata, or use the build-update target.

This is a quickfix to put out the fire.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 18, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Aug 18, 2025

/approve

@openshift-ci openshift-ci bot requested review from anik120 and perdasilva August 18, 2025 13:35
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2025
anik120
anik120 approved these changes Aug 18, 2025
View reviewed changes
Copy link
Contributor

@anik120 anik120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86 camilamacedo86 mentioned this pull request Aug 18, 2025
Closed
@tmshort
Copy link
Contributor Author

tmshort commented Aug 18, 2025 •
edited
Loading

This is a faster test than the openshift-e2e-aws tests. It's also passing in the other two reapply PRs, and this has PR has nothing to do with that test.
/test e2e-aws-techpreview-olmv1-ext

@tmshort
Copy link
Contributor Author

tmshort commented Aug 18, 2025

/override openshift-e2e-aws
Known flake

: [sig-instrumentation] Metrics should grab all metrics from kubelet /metrics/resource endpoint [Suite:openshift/conformance/parallel] [Suite:k8s]

@tmshort
Copy link
Contributor Author

tmshort commented Aug 18, 2025

/skip

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 18, 2025

@tmshort: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • openshift-e2e-aws

Only the following failed contexts/checkruns were expected:

  • ci/prow/check-sync-pr-valid
  • ci/prow/e2e-aws-techpreview-olmv1-ext
  • ci/prow/images
  • ci/prow/okd-scos-e2e-aws-ovn
  • ci/prow/okd-scos-images
  • ci/prow/openshift-e2e-aws
  • ci/prow/openshift-e2e-aws-techpreview
  • ci/prow/tests-extension
  • ci/prow/unit
  • ci/prow/verify
  • ci/prow/verify-commits
  • ci/prow/verify-deps
  • pull-ci-openshift-operator-framework-operator-controller-main-check-sync-pr-valid
  • pull-ci-openshift-operator-framework-operator-controller-main-e2e-aws-techpreview-olmv1-ext
  • pull-ci-openshift-operator-framework-operator-controller-main-images
  • pull-ci-openshift-operator-framework-operator-controller-main-okd-scos-e2e-aws-ovn
  • pull-ci-openshift-operator-framework-operator-controller-main-okd-scos-images
  • pull-ci-openshift-operator-framework-operator-controller-main-openshift-e2e-aws
  • pull-ci-openshift-operator-framework-operator-controller-main-openshift-e2e-aws-techpreview
  • pull-ci-openshift-operator-framework-operator-controller-main-tests-extension
  • pull-ci-openshift-operator-framework-operator-controller-main-unit
  • pull-ci-openshift-operator-framework-operator-controller-main-verify
  • pull-ci-openshift-operator-framework-operator-controller-main-verify-commits
  • pull-ci-openshift-operator-framework-operator-controller-main-verify-deps
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override openshift-e2e-aws
Known flake

: [sig-instrumentation] Metrics should grab all metrics from kubelet /metrics/resource endpoint [Suite:openshift/conformance/parallel] [Suite:k8s]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tmshort
Copy link
Contributor Author

tmshort commented Aug 18, 2025

/override ci/prow/openshift-e2e-aws
/skip
Known flake

: [sig-instrumentation] Metrics should grab all metrics from kubelet /metrics/resource endpoint [Suite:openshift/conformance/parallel] [Suite:k8s]

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 18, 2025

@tmshort: Overrode contexts on behalf of tmshort: ci/prow/openshift-e2e-aws

In response to this:

/override ci/prow/openshift-e2e-aws
/skip
Known flake

: [sig-instrumentation] Metrics should grab all metrics from kubelet /metrics/resource endpoint [Suite:openshift/conformance/parallel] [Suite:k8s]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tmshort
Copy link
Contributor Author

tmshort commented Aug 18, 2025

#434 (comment)

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 05ea7c9 and 2 for PR HEAD 6b41cbb in total

@tmshort
Copy link
Contributor Author

tmshort commented Aug 18, 2025

/override ci/prow/openshift-e2e-aws
/skip
Known flake

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 18, 2025

@tmshort: Overrode contexts on behalf of tmshort: ci/prow/openshift-e2e-aws

In response to this:

/override ci/prow/openshift-e2e-aws
/skip
Known flake

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 94200dd into openshift:main Aug 18, 2025
13 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 18, 2025

@tmshort: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 6b41cbb link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-olm-operator-controller
This PR has been included in build ose-olm-operator-controller-container-v4.20.0-202508190038.p0.g94200dd.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-olm-catalogd
This PR has been included in build ose-olm-catalogd-container-v4.20.0-202508190038.p0.g94200dd.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perdasilva perdasilva Awaiting requested review from perdasilva

1 more reviewer

@anik120 anik120 anik120 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@anik120 anik120

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tmshort @openshift-ci-robot @openshift-bot @anik120