Skip to content

NO-ISSUE: Remove test with issue scenario that cause need to revert all webhook tests #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Aug 18, 2025

Because of the problem reported here: Slack thread,
The entire PR was reverted last week: #434.

However, the bumper/sync process re-added the changes.
In this PR, I’m removing the problematic test. This seems like the simplest way to fix the bumper issue while keeping the other tests, which we do want to include.

@openshift-ci openshift-ci bot requested review from bentito and dtfranz August 18, 2025 12:53
Copy link
Contributor

openshift-ci bot commented Aug 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: camilamacedo86
Once this PR has been reviewed and has the lgtm label, please assign oceanc80 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86 camilamacedo86 changed the title UPSTREAM: <carry>: OTE : Remove test with issue scenario that cause revert webhook tests NO-ISSUE: UPSTREAM: <carry>: OTE : Remove test with issue scenario that cause revert webhook tests Aug 18, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 18, 2025
@openshift-ci-robot
Copy link

@camilamacedo86: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86 camilamacedo86 changed the title NO-ISSUE: UPSTREAM: <carry>: OTE : Remove test with issue scenario that cause revert webhook tests NO-ISSUE: Remove test with issue scenario that cause need to revert all webhook tests Aug 18, 2025
@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Aug 18, 2025

Close in favor:

NO-ISSUE: Remove bindata generation from build [reapply]
OPRUN-4070: Revert [OTE] add webhook tests [reapply]
OPRUN-3890,OPRUN-3983: Upgrade OCP Catalog images from 4.19 to 4.20 [reapply]

We lost more commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants