OCPBUGS-39574: (fix) registry pods do not come up again after node failure (#3366)

[anik120]

PR 3201 attempted to solve for the issue by deleting the pods stuck in Terminating due to unreachable node. However, the logic to do that was included in EnsureRegistryServer, which only gets executed if polling in requested by the user.

This PR moves the logic of checking for dead pods out of EnsureRegistryServer, and puts it in CheckRegistryServer instead. This way, if there are any dead pods detected during CheckRegistryServer, the value of healthy is returned false, which inturn triggers EnsureRegistryServer.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: f2431893193e7112f78298ad7682ff3e1b179d8c

[openshift-ci-robot]

@anik120: This pull request references Jira Issue OCPBUGS-39574, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected dependent Jira Issue OCPBUGS-36661 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

PR 3201 attempted to solve for the issue by deleting the pods stuck in Terminating due to unreachable node. However, the logic to do that was included in EnsureRegistryServer, which only gets executed if polling in requested by the user.

This PR moves the logic of checking for dead pods out of EnsureRegistryServer, and puts it in CheckRegistryServer instead. This way, if there are any dead pods detected during CheckRegistryServer, the value of healthy is returned false, which inturn triggers EnsureRegistryServer.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: f2431893193e7112f78298ad7682ff3e1b179d8c

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [anik120]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[anik120]

/jira refresh

[openshift-ci-robot]

@anik120: This pull request references Jira Issue OCPBUGS-39574, which is invalid:

• expected dependent Jira Issue OCPBUGS-36661 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[anik120]

/retest

[jianzhangbjz]

/jira refresh

[openshift-ci-robot]

@jianzhangbjz: This pull request references Jira Issue OCPBUGS-39574, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.0) matches configured target version for branch (4.17.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-36661 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Jira Issue OCPBUGS-36661 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jianzhangbjz]

Pre-merge test pass, details: https://issues.redhat.com//browse/OCPBUGS-39574
/lgtm
/label qe-approved
/label cherry-pick-approved

[openshift-ci-robot]

@anik120: This pull request references Jira Issue OCPBUGS-39574, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.0) matches configured target version for branch (4.17.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-36661 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Jira Issue OCPBUGS-36661 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

Details

In response to this:

PR 3201 attempted to solve for the issue by deleting the pods stuck in Terminating due to unreachable node. However, the logic to do that was included in EnsureRegistryServer, which only gets executed if polling in requested by the user.

This PR moves the logic of checking for dead pods out of EnsureRegistryServer, and puts it in CheckRegistryServer instead. This way, if there are any dead pods detected during CheckRegistryServer, the value of healthy is returned false, which inturn triggers EnsureRegistryServer.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: f2431893193e7112f78298ad7682ff3e1b179d8c

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[perdasilva]

/retest

[jianzhangbjz]

Hi @perdasilva , I guess it needs the backport-risk-assessed label.

[perdasilva]

/label backport-risk-assessed

[perdasilva]

/retest

[openshift-ci-robot]

@anik120: Jira Issue OCPBUGS-39574: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

• openshift/operator-framework-olm#854 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-39574 has not been moved to the MODIFIED state.

Details

In response to this:

PR 3201 attempted to solve for the issue by deleting the pods stuck in Terminating due to unreachable node. However, the logic to do that was included in EnsureRegistryServer, which only gets executed if polling in requested by the user.

This PR moves the logic of checking for dead pods out of EnsureRegistryServer, and puts it in CheckRegistryServer instead. This way, if there are any dead pods detected during CheckRegistryServer, the value of healthy is returned false, which inturn triggers EnsureRegistryServer.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: f2431893193e7112f78298ad7682ff3e1b179d8c

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[anik120]

/jira refresh

[openshift-ci-robot]

@anik120: Jira Issue OCPBUGS-39574: All pull requests linked via external trackers have merged:

• openshift/operator-framework-olm#855

Jira Issue OCPBUGS-39574 has been moved to the MODIFIED state.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: operator-lifecycle-manager
This PR has been included in build operator-lifecycle-manager-container-v4.17.0-202409061435.p0.gff240fe.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: operator-registry
This PR has been included in build operator-registry-container-v4.17.0-202409061435.p0.gff240fe.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-operator-framework-tools
This PR has been included in build ose-operator-framework-tools-container-v4.17.0-202409061435.p0.gff240fe.assembly.stream.el9.
All builds following this will include this PR.