OCPBUGS-41217: (fix) registry pods do not come up again after node failure (#3366) #854

anik120 · 2024-09-04T14:57:16Z

PR 3201 attempted to solve for the issue by deleting the pods stuck in Terminating due to unreachable node. However, the logic to do that was included in EnsureRegistryServer, which only gets executed if polling in requested by the user.

This PR moves the logic of checking for dead pods out of EnsureRegistryServer, and puts it in CheckRegistryServer instead. This way, if there are any dead pods detected during CheckRegistryServer, the value of healthy is returned false, which inturn triggers EnsureRegistryServer.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: f2431893193e7112f78298ad7682ff3e1b179d8c

[PR 3201](operator-framework/operator-lifecycle-manager#3201) attempted to solve for the issue by deleting the pods stuck in `Terminating` due to unreachable node. However, the logic to do that was included in `EnsureRegistryServer`, which only gets executed if polling in requested by the user. This PR moves the logic of checking for dead pods out of `EnsureRegistryServer`, and puts it in `CheckRegistryServer` instead. This way, if there are any dead pods detected during `CheckRegistryServer`, the value of `healthy` is returned `false`, which inturn triggers `EnsureRegistryServer`. Upstream-repository: operator-lifecycle-manager Upstream-commit: f2431893193e7112f78298ad7682ff3e1b179d8c

openshift-ci-robot · 2024-09-04T14:57:24Z

@anik120: This pull request references Jira Issue OCPBUGS-39574, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-36661 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead
expected dependent Jira Issue OCPBUGS-36661 to target a version in 4.17.0, but it targets "4.18" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

PR 3201 attempted to solve for the issue by deleting the pods stuck in Terminating due to unreachable node. However, the logic to do that was included in EnsureRegistryServer, which only gets executed if polling in requested by the user.

This PR moves the logic of checking for dead pods out of EnsureRegistryServer, and puts it in CheckRegistryServer instead. This way, if there are any dead pods detected during CheckRegistryServer, the value of healthy is returned false, which inturn triggers EnsureRegistryServer.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: f2431893193e7112f78298ad7682ff3e1b179d8c

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-09-04T14:59:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~DOWNSTREAM_OWNERS~~ [anik120]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

anik120 · 2024-09-04T16:11:48Z

/jira refresh

openshift-ci-robot · 2024-09-04T16:11:51Z

@anik120: This pull request references Jira Issue OCPBUGS-39574, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-36661 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead
expected dependent Jira Issue OCPBUGS-36661 to target a version in 4.17.0, but it targets "4.17" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

anik120 · 2024-09-04T16:13:14Z

/jira refresh

openshift-ci-robot · 2024-09-04T16:13:18Z

@anik120: This pull request references Jira Issue OCPBUGS-39574, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-36661 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

anik120 · 2024-09-04T16:13:38Z

/cherrypick release-4.15

openshift-cherrypick-robot · 2024-09-04T16:13:40Z

@anik120: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

anik120 · 2024-09-04T16:13:53Z

/retest

anik120 · 2024-09-04T18:53:47Z

/retest

anik120 · 2024-09-04T20:10:59Z

/retest

dtfranz · 2024-09-04T21:00:18Z

/lgtm

dtfranz · 2024-09-04T22:14:22Z

/retest-required

kevinrizza · 2024-09-05T13:29:58Z

/label backport-risk-assessed

openshift-ci-robot · 2024-09-05T14:27:11Z

@anik120: This pull request references Jira Issue OCPBUGS-41217, which is invalid:

expected Jira Issue OCPBUGS-41217 to depend on a bug targeting a version in 4.17.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

PR 3201 attempted to solve for the issue by deleting the pods stuck in Terminating due to unreachable node. However, the logic to do that was included in EnsureRegistryServer, which only gets executed if polling in requested by the user.

This PR moves the logic of checking for dead pods out of EnsureRegistryServer, and puts it in CheckRegistryServer instead. This way, if there are any dead pods detected during CheckRegistryServer, the value of healthy is returned false, which inturn triggers EnsureRegistryServer.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: f2431893193e7112f78298ad7682ff3e1b179d8c

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

anik120 · 2024-09-05T14:27:16Z

/jira refresh

openshift-ci-robot · 2024-09-05T14:27:21Z

@anik120: This pull request references Jira Issue OCPBUGS-41217, which is invalid:

expected Jira Issue OCPBUGS-41217 to depend on a bug targeting a version in 4.17.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

anik120 · 2024-09-05T14:29:53Z

/jira refresh

openshift-ci-robot · 2024-09-05T14:29:56Z

@anik120: This pull request references Jira Issue OCPBUGS-41217, which is invalid:

expected dependent Jira Issue OCPBUGS-39574 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dtfranz · 2024-09-05T15:53:56Z

/retest-required

perdasilva · 2024-09-06T07:42:18Z

/jira refresh
/retest

openshift-ci-robot · 2024-09-06T07:42:24Z

@perdasilva: This pull request references Jira Issue OCPBUGS-41217, which is invalid:

expected dependent Jira Issue OCPBUGS-39574 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-09-06T09:32:46Z

@anik120: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-olm-flaky	`dd9bf6d`	link	false	`/test e2e-gcp-olm-flaky`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

anik120 · 2024-09-06T15:42:44Z

/jira refresh

openshift-ci-robot · 2024-09-06T15:42:47Z

@anik120: This pull request references Jira Issue OCPBUGS-41217, which is invalid:

expected dependent Jira Issue OCPBUGS-39574 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

anik120 · 2024-09-06T19:16:36Z

/jira refresh

openshift-ci-robot · 2024-09-06T19:16:40Z

@anik120: This pull request references Jira Issue OCPBUGS-41217, which is invalid:

expected dependent Jira Issue OCPBUGS-39574 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jianzhangbjz · 2024-09-09T01:45:22Z

/jira refresh

openshift-ci-robot · 2024-09-09T01:45:29Z

@jianzhangbjz: This pull request references Jira Issue OCPBUGS-41217, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.z) matches configured target version for branch (4.16.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-39574 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-39574 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jianzhangbjz · 2024-09-09T09:00:28Z

Build the cluster always fails, retring...
see: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/release-openshift-origin-installer-launch-openstack/1833052471853846528

jianzhangbjz · 2024-09-09T10:04:37Z

Test pass, details: https://issues.redhat.com/browse/OCPBUGS-41217
/lgtm
/label qe-approved
/label cherry-pick-approved

openshift-ci-robot · 2024-09-09T10:04:45Z

@anik120: This pull request references Jira Issue OCPBUGS-41217, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.z) matches configured target version for branch (4.16.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-39574 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-39574 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

Details

In response to this:

PR 3201 attempted to solve for the issue by deleting the pods stuck in Terminating due to unreachable node. However, the logic to do that was included in EnsureRegistryServer, which only gets executed if polling in requested by the user.

This PR moves the logic of checking for dead pods out of EnsureRegistryServer, and puts it in CheckRegistryServer instead. This way, if there are any dead pods detected during CheckRegistryServer, the value of healthy is returned false, which inturn triggers EnsureRegistryServer.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: f2431893193e7112f78298ad7682ff3e1b179d8c

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-09-09T10:09:10Z

@anik120: Jira Issue OCPBUGS-41217: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#854

Jira Issue OCPBUGS-41217 has been moved to the MODIFIED state.

Details

In response to this:

PR 3201 attempted to solve for the issue by deleting the pods stuck in Terminating due to unreachable node. However, the logic to do that was included in EnsureRegistryServer, which only gets executed if polling in requested by the user.

This PR moves the logic of checking for dead pods out of EnsureRegistryServer, and puts it in CheckRegistryServer instead. This way, if there are any dead pods detected during CheckRegistryServer, the value of healthy is returned false, which inturn triggers EnsureRegistryServer.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: f2431893193e7112f78298ad7682ff3e1b179d8c

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2024-09-09T10:10:03Z

@anik120: #854 failed to apply on top of branch "release-4.15":

Applying: (fix) registry pods do not come up again after node failure (#3366)
Using index info to reconstruct a base tree...
M	staging/operator-lifecycle-manager/pkg/controller/registry/reconciler/configmap.go
M	staging/operator-lifecycle-manager/pkg/controller/registry/reconciler/configmap_test.go
M	staging/operator-lifecycle-manager/pkg/controller/registry/reconciler/grpc.go
M	staging/operator-lifecycle-manager/pkg/controller/registry/reconciler/grpc_test.go
M	vendor/github.com/operator-framework/operator-lifecycle-manager/pkg/controller/registry/reconciler/configmap.go
M	vendor/github.com/operator-framework/operator-lifecycle-manager/pkg/controller/registry/reconciler/grpc.go
Falling back to patching base and 3-way merge...
Auto-merging vendor/github.com/operator-framework/operator-lifecycle-manager/pkg/controller/registry/reconciler/grpc.go
CONFLICT (content): Merge conflict in vendor/github.com/operator-framework/operator-lifecycle-manager/pkg/controller/registry/reconciler/grpc.go
Auto-merging vendor/github.com/operator-framework/operator-lifecycle-manager/pkg/controller/registry/reconciler/configmap.go
CONFLICT (content): Merge conflict in vendor/github.com/operator-framework/operator-lifecycle-manager/pkg/controller/registry/reconciler/configmap.go
Auto-merging staging/operator-lifecycle-manager/pkg/controller/registry/reconciler/grpc_test.go
Auto-merging staging/operator-lifecycle-manager/pkg/controller/registry/reconciler/grpc.go
CONFLICT (content): Merge conflict in staging/operator-lifecycle-manager/pkg/controller/registry/reconciler/grpc.go
Auto-merging staging/operator-lifecycle-manager/pkg/controller/registry/reconciler/configmap_test.go
Auto-merging staging/operator-lifecycle-manager/pkg/controller/registry/reconciler/configmap.go
CONFLICT (content): Merge conflict in staging/operator-lifecycle-manager/pkg/controller/registry/reconciler/configmap.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 (fix) registry pods do not come up again after node failure (#3366)
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-bot · 2024-09-09T12:18:44Z

[ART PR BUILD NOTIFIER]

Distgit: operator-lifecycle-manager
This PR has been included in build operator-lifecycle-manager-container-v4.16.0-202409091136.p0.gd2feafe.assembly.stream.el9.
All builds following this will include this PR.

openshift-bot · 2024-09-09T12:24:44Z

[ART PR BUILD NOTIFIER]

Distgit: operator-registry
This PR has been included in build operator-registry-container-v4.16.0-202409091136.p0.gd2feafe.assembly.stream.el9.
All builds following this will include this PR.

openshift-bot · 2024-09-09T12:27:45Z

[ART PR BUILD NOTIFIER]

Distgit: ose-operator-framework-tools
This PR has been included in build ose-operator-framework-tools-container-v4.16.0-202409091136.p0.gd2feafe.assembly.stream.el9.
All builds following this will include this PR.

openshift-ci bot requested review from perdasilva and tmshort September 4, 2024 14:58

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2024

openshift-ci bot assigned dtfranz Sep 4, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2024

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 5, 2024

openshift-ci bot assigned bandrade, emmajiafan, jianzhangbjz, KeenonLee, kuiwang02 and Xia-Zhao-rh Sep 5, 2024

anik120 changed the title ~~OCPBUGS-39574: (fix) registry pods do not come up again after node failure (#3366)~~ OCPBUGS-41217: (fix) registry pods do not come up again after node failure (#3366) Sep 5, 2024

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 9, 2024

openshift-ci bot added qe-approved Signifies that QE has signed off on this PR cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Sep 9, 2024

openshift-merge-bot bot merged commit d2feafe into openshift:release-4.16 Sep 9, 2024

OCPBUGS-41217: (fix) registry pods do not come up again after node failure (#3366) #854

OCPBUGS-41217: (fix) registry pods do not come up again after node failure (#3366) #854

Uh oh!

Conversation

anik120 commented Sep 4, 2024

Uh oh!

openshift-ci-robot commented Sep 4, 2024

Uh oh!

openshift-ci bot commented Sep 4, 2024

Uh oh!

anik120 commented Sep 4, 2024

Uh oh!

openshift-ci-robot commented Sep 4, 2024

Uh oh!

anik120 commented Sep 4, 2024

Uh oh!

openshift-ci-robot commented Sep 4, 2024

Uh oh!

anik120 commented Sep 4, 2024

Uh oh!

openshift-cherrypick-robot commented Sep 4, 2024

Uh oh!

anik120 commented Sep 4, 2024

Uh oh!

anik120 commented Sep 4, 2024

Uh oh!

anik120 commented Sep 4, 2024

Uh oh!

dtfranz commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dtfranz commented Sep 4, 2024

Uh oh!

kevinrizza commented Sep 5, 2024

Uh oh!

openshift-ci-robot commented Sep 5, 2024

Uh oh!

anik120 commented Sep 5, 2024

Uh oh!

openshift-ci-robot commented Sep 5, 2024

Uh oh!

anik120 commented Sep 5, 2024

Uh oh!

openshift-ci-robot commented Sep 5, 2024

Uh oh!

dtfranz commented Sep 5, 2024

Uh oh!

perdasilva commented Sep 6, 2024

Uh oh!

openshift-ci-robot commented Sep 6, 2024

Uh oh!

openshift-ci bot commented Sep 6, 2024

Uh oh!

anik120 commented Sep 6, 2024

Uh oh!

openshift-ci-robot commented Sep 6, 2024

Uh oh!

anik120 commented Sep 6, 2024

Uh oh!

openshift-ci-robot commented Sep 6, 2024

Uh oh!

jianzhangbjz commented Sep 9, 2024

Uh oh!

openshift-ci-robot commented Sep 9, 2024

Uh oh!

jianzhangbjz commented Sep 9, 2024

Uh oh!

jianzhangbjz commented Sep 9, 2024

Uh oh!

openshift-ci-robot commented Sep 9, 2024

Uh oh!

openshift-ci-robot commented Sep 9, 2024

Uh oh!

openshift-cherrypick-robot commented Sep 9, 2024

Uh oh!

openshift-bot commented Sep 9, 2024

Uh oh!

openshift-bot commented Sep 9, 2024

Uh oh!

openshift-bot commented Sep 9, 2024

dtfranz commented Sep 4, 2024 •

edited

Loading