Skip to content

Conversation

@mandre
Copy link
Member

@mandre mandre commented Jan 31, 2023

v0.7.0

Conflicts:
      OWNERS
      OWNERS_ALIASES
      api/v1alpha6/openstackcluster_webhook.go
      api/v1alpha6/openstackcluster_webhook_test.go
      api/v1alpha6/openstackclusterlist_webhook.go
      api/v1alpha6/openstackclustertemplate_webhook.go
      api/v1alpha6/openstackmachine_webhook.go
      api/v1alpha6/openstackmachinelist_webhook.go
      api/v1alpha6/openstackmachinetemplate_webhook_test.go
      api/v1alpha6/openstackmachinetemplatelist_webhook.go
      api/v1alpha6/webhooks.go
      config/webhook/manifests.yaml
      controllers/openstackcluster_controller.go
      metadata.yaml

jichenjc and others added 30 commits April 4, 2022 10:06
We use the CAPI release-note tool and they switched the icon for other from
`:running:` to `:seedling:`.

This caused issues with the latest release
because the title for many PRs could not be automatically parsed and we
needed to fix the generated release notes manually.

The new text is a direct copy of CAPI PULL_REQUEST_TEMPLATE.md.
…or-icon

🏃 update PR icon template to match CAPI
🌱 Update RELEASE.md process for release branches
…ion-nil-pointer

🐛 Fix nil pointer reference during bastion deletion
…aintainer

move chrischdi to emeritus_approvers
Unfortunately, I haven't much time nowadays to contribute and participate in reviews. Hope to be back contributing again soon!
🌱 Remove macaptain from cluster-api-openstack-reviewers
We were using some deprecated ginkgo functionality. Namely running tests asynchronously and using a custom reporter.
This commit fixes those warnings by running the tests synchronously and
using the standard reporter.
In order to use envtest for these tests, it was necessary to add the
CRDs for CAPI clusters and machines. Luckily I found a way to only
include the minimal required parts instead of the full thing. This
solution is taken from CAPA.
* as we already have webhooks for v1alpha5 we don't need webhooks for
older versions anymore.
* remove v1alpha4 from webhook mgr setup
* remove defaultIdentityRefKind const in v1alpha4

Signed-off-by: Mario Constanti <[email protected]>
…renaming

 🐛 remove webhooks for old APIversion v1alpha4
…controller-tests

🏃 Add tests for cluster controller
refactory test code (reuse existing function)
…terclass

🐛 implement conversion for OpenStackClusterTemplate CRD
Passing security groups by specifying more options in addition to UUIDs on ports
✨ bump golangci-lint version to v1.46.2
tobiasgiese and others added 16 commits December 8, 2022 11:39
During this bump we must upgrade Golang to 1.19 as well.

Signed-off-by: Tobias Giese <[email protected]>
Signed-off-by: Tobias Giese <[email protected]>
This reverts commit 32a9fc9.

Signed-off-by: Tobias Giese <[email protected]>
Signed-off-by: Tobias Giese <[email protected]>
…ot/cherry-pick-1406-to-release-0.7

[release-0.7] ✨ Bump CAPI to v1.3.0
The ClusterctlUpgradeSpec contains a BeforeEach block so it cannot be
nested in an It block.

(cherry picked from commit b2bdc35)
Revert the workaround in clusterctl upgrade

(cherry picked from commit c4229c9)
…ot/cherry-pick-1421-to-release-0.7

[release-0.7] ✨Add lentzi90 to reviewers
…ot/cherry-pick-1424-to-release-0.7

[release-0.7] 🌱Bump CAPI to v1.3.1
in the initial reconciliation loop, a nil-pointer occurs if the cluster
is configured with a bastion host. In this initial run the status field
is still empty.

Signed-off-by: Mario Constanti <[email protected]>
…ot/cherry-pick-1445-to-release-0.7

[release-0.7] 🐛 fix nil-pointer in initial reconciliation loop with empty status field
v0.7.0

Conflicts:
      OWNERS
      OWNERS_ALIASES
      api/v1alpha6/openstackcluster_webhook.go
      api/v1alpha6/openstackcluster_webhook_test.go
      api/v1alpha6/openstackclusterlist_webhook.go
      api/v1alpha6/openstackclustertemplate_webhook.go
      api/v1alpha6/openstackmachine_webhook.go
      api/v1alpha6/openstackmachinelist_webhook.go
      api/v1alpha6/openstackmachinetemplate_webhook_test.go
      api/v1alpha6/openstackmachinetemplatelist_webhook.go
      api/v1alpha6/webhooks.go
      config/webhook/manifests.yaml
      controllers/openstackcluster_controller.go
      metadata.yaml
@openshift-ci
Copy link

openshift-ci bot commented Jan 31, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mandre by writing /assign @mandre in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mandre
Copy link
Member Author

mandre commented Feb 1, 2023

/hold
We want to merge this into a release-0.7 (or similarly named) branch.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2023
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 3, 2023
@mandre
Copy link
Member Author

mandre commented May 4, 2023

/retest

@openshift-ci
Copy link

openshift-ci bot commented May 4, 2023

@mandre: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 9bb6e58 link false /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandre
Copy link
Member Author

mandre commented May 10, 2023

This is no longer needed, we now have a synced release-0.7 branch.
/close

@openshift-ci openshift-ci bot closed this May 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 10, 2023

@mandre: Closed this PR.

In response to this:

This is no longer needed, we now have a synced release-0.7 branch.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti deleted the merge-upstream branch May 10, 2023 09:02
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
have following in log:
E0308 08:36:06.485556       1 actuator.go:233] master inplace update failed: <nil>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Projects

None yet

Development

Successfully merging this pull request may close these issues.