-
Notifications
You must be signed in to change notification settings - Fork 33
Merge upstream tag v0.7.0 #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mandre
commented
Jan 31, 2023
🌱 Add release 0.6.x to metadata.yaml
📖 allow up to 20 tabs in book
We use the CAPI release-note tool and they switched the icon for other from `:running:` to `:seedling:`. This caused issues with the latest release because the title for many PRs could not be automatically parsed and we needed to fix the generated release notes manually. The new text is a direct copy of CAPI PULL_REQUEST_TEMPLATE.md.
…or-icon 🏃 update PR icon template to match CAPI
Co-authored-by: Julian Tölle <[email protected]>
🌱 Update RELEASE.md process for release branches
…ion-nil-pointer 🐛 Fix nil pointer reference during bastion deletion
…aintainer move chrischdi to emeritus_approvers
Unfortunately, I haven't much time nowadays to contribute and participate in reviews. Hope to be back contributing again soon!
🌱 Remove macaptain from cluster-api-openstack-reviewers
We were using some deprecated ginkgo functionality. Namely running tests asynchronously and using a custom reporter. This commit fixes those warnings by running the tests synchronously and using the standard reporter.
…go-warnings 🌱 Fix ginkgo warnings
In order to use envtest for these tests, it was necessary to add the CRDs for CAPI clusters and machines. Luckily I found a way to only include the minimal required parts instead of the full thing. This solution is taken from CAPA.
* as we already have webhooks for v1alpha5 we don't need webhooks for older versions anymore. * remove v1alpha4 from webhook mgr setup * remove defaultIdentityRefKind const in v1alpha4 Signed-off-by: Mario Constanti <[email protected]>
…renaming 🐛 remove webhooks for old APIversion v1alpha4
…controller-tests 🏃 Add tests for cluster controller
refactory test code (reuse existing function)
…terclass 🐛 implement conversion for OpenStackClusterTemplate CRD
Passing security groups by specifying more options in addition to UUIDs on ports
cleanup: remove used file
Signed-off-by: Prajyot-Parab <[email protected]>
✨ bump golangci-lint version to v1.46.2
During this bump we must upgrade Golang to 1.19 as well. Signed-off-by: Tobias Giese <[email protected]>
Signed-off-by: Tobias Giese <[email protected]>
This reverts commit 32a9fc9. Signed-off-by: Tobias Giese <[email protected]>
Signed-off-by: Tobias Giese <[email protected]>
…ot/cherry-pick-1406-to-release-0.7 [release-0.7] ✨ Bump CAPI to v1.3.0
The ClusterctlUpgradeSpec contains a BeforeEach block so it cannot be nested in an It block. (cherry picked from commit b2bdc35)
Revert the workaround in clusterctl upgrade (cherry picked from commit c4229c9)
…atches 🌱 Backport E2E test fixes
…ot/cherry-pick-1421-to-release-0.7 [release-0.7] ✨Add lentzi90 to reviewers
…ot/cherry-pick-1424-to-release-0.7 [release-0.7] 🌱Bump CAPI to v1.3.1
in the initial reconciliation loop, a nil-pointer occurs if the cluster is configured with a bastion host. In this initial run the status field is still empty. Signed-off-by: Mario Constanti <[email protected]>
…ot/cherry-pick-1445-to-release-0.7 [release-0.7] 🐛 fix nil-pointer in initial reconciliation loop with empty status field
v0.7.0
Conflicts:
OWNERS
OWNERS_ALIASES
api/v1alpha6/openstackcluster_webhook.go
api/v1alpha6/openstackcluster_webhook_test.go
api/v1alpha6/openstackclusterlist_webhook.go
api/v1alpha6/openstackclustertemplate_webhook.go
api/v1alpha6/openstackmachine_webhook.go
api/v1alpha6/openstackmachinelist_webhook.go
api/v1alpha6/openstackmachinetemplate_webhook_test.go
api/v1alpha6/openstackmachinetemplatelist_webhook.go
api/v1alpha6/webhooks.go
config/webhook/manifests.yaml
controllers/openstackcluster_controller.go
metadata.yaml
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
/retest |
|
@mandre: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
This is no longer needed, we now have a synced |
|
@mandre: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
have following in log: E0308 08:36:06.485556 1 actuator.go:233] master inplace update failed: <nil>