Skip to content

🌱 Backport E2E test fixes #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 13, 2022
Merged

🌱 Backport E2E test fixes #1420

merged 2 commits into from
Dec 13, 2022

Conversation

@mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Dec 13, 2022

What this PR does / why we need it:
This cherry picks #1412 and #1417 from main.

/hold

@lentzi90 @mdbooth
Remove It block from clusterctl upgrade
e026837 
The ClusterctlUpgradeSpec contains a BeforeEach block so it cannot be
nested in an It block.

(cherry picked from commit b2bdc35)
@lentzi90 @mdbooth
e2e: Change logging to avoid use of By
0bf2da8 
Revert the workaround in clusterctl upgrade

(cherry picked from commit c4229c9)
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2022
@netlify
Copy link

netlify bot commented Dec 13, 2022 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 0bf2da8
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/63984f12dc146c0008fa8051
😎 Deploy Preview https://deploy-preview-1420--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 13, 2022
@mdbooth
Copy link
Contributor Author

mdbooth commented Dec 13, 2022

/test pull-cluster-api-provider-openstack-e2e-full-test

@jichenjc
Copy link
Contributor

jichenjc commented Dec 13, 2022

/assign lentiz90

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 13, 2022

@jichenjc: GitHub didn't allow me to assign the following users: lentiz90.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign lentiz90

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jichenjc
Copy link
Contributor

jichenjc commented Dec 13, 2022

@lentzi90 can you help check this ? Thanks

lentzi90
lentzi90 approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me!
I guess I cannot do this but anyway
/lgtm

Edit: Really I am allowed to put lgtm? 😮 🎉 😎

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jichenjc
Copy link
Contributor

jichenjc commented Dec 13, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2022
@mdbooth
Copy link
Contributor Author

mdbooth commented Dec 13, 2022

The pull-cluster-api-provider-openstack-e2e-full-test job succeeded, which was the interesting one.

@mdbooth
Copy link
Contributor Author

mdbooth commented Dec 13, 2022

/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit e010ec0 into kubernetes-sigs:release-0.7 Dec 13, 2022
@mdbooth mdbooth deleted the release-0.7-patches branch December 13, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lentzi90 lentzi90 lentzi90 approved these changes

@jichenjc jichenjc Awaiting requested review from jichenjc

@seanschneeweiss seanschneeweiss Awaiting requested review from seanschneeweiss

Assignees

@lentzi90 lentzi90

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mdbooth @jichenjc @k8s-ci-robot @lentzi90