Skip to content

Set DisableKubeletCloudCredentialProviders upstream feature gate to False #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2023
Merged

Set DisableKubeletCloudCredentialProviders upstream feature gate to False #1693

merged 1 commit into from
Dec 5, 2023

Conversation

JoelSpeed
Copy link
Contributor

Based on discussion in https://redhat-internal.slack.com/archives/C065R4NCLGM/p1701682788330769, we need to disable this feature gate until we have time to test and configure the credentials providers.

This will require us to make changes in the MCO to set up new configuration and run the credentials binaries on the host.

CC @elmiko @soltysh

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

Hello @JoelSpeed! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 4, 2023
soltysh
soltysh approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold
for @elmiko

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2023
@openshift-ci openshift-ci bot requested review from bparees and sjenning December 4, 2023 14:31
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2023
@elmiko
Copy link
Contributor

elmiko commented Dec 4, 2023

sorry for previous comment, i misread. this should be fine if we are using this feature, but i had thought it was only use on gcp when running --cloud-provider=gce, unless we also run a registry credential provider.

@elmiko
Copy link
Contributor

elmiko commented Dec 4, 2023

i talked with @JoelSpeed about this, it should be set false for now.

/lgtm
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, JoelSpeed, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JoelSpeed
Copy link
Contributor Author

/hold

I want to manually verify e2e before merging

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2023
@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented Dec 4, 2023 •
edited
Loading

Checking payload, I can see the feature gate is now disabled in the cluster, however, it's not being passed to kubelet. Looks like MCO is only taking into account those feature gates that are enabled, which means we have no way to explicitly disable an upstream feature gate currently.

We need to fix this MCO bug before we proceed

@JoelSpeed
Copy link
Contributor Author

/hold cancel

Have verified in the rendered MC that it has the correct gates set

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2023
@JoelSpeed
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b5716b3 and 2 for PR HEAD 5fe3654 in total

@soltysh
Copy link
Contributor

soltysh commented Dec 5, 2023

/test verify-client-go

@sairameshv
Copy link
Member 

Go compliance shim [13] [][]: invoking real go binary
# github.com/openshift/client-go/config/applyconfigurations/config/v1
config/applyconfigurations/config/v1/baremetalplatformspec.go:12:28: undefined: v1.IP
config/applyconfigurations/config/v1/baremetalplatformspec.go:13:28: undefined: v1.IP
config/applyconfigurations/config/v1/baremetalplatformspec.go:14:28: undefined: v1.CIDR
config/applyconfigurations/config/v1/baremetalplatformspec.go:26:89: undefined: v1.IP
config/applyconfigurations/config/v1/baremetalplatformspec.go:36:79: undefined: v1.IP
config/applyconfigurations/config/v1/baremetalplatformspec.go:46:84: undefined: v1.CIDR
config/applyconfigurations/config/v1/openstackplatformspec.go:12:28: undefined: v1.IP
config/applyconfigurations/config/v1/openstackplatformspec.go:13:28: undefined: v1.IP
config/applyconfigurations/config/v1/openstackplatformspec.go:14:28: undefined: v1.CIDR
config/applyconfigurations/config/v1/openstackplatformspec.go:26:89: undefined: v1.IP
config/applyconfigurations/config/v1/openstackplatformspec.go:26:89: too many errors
Go compliance shim [13] [][]: Exited with: 1

@JoelSpeed, is this failure valid for the failing verify-client-go job?

@JoelSpeed
Copy link
Contributor Author

openshift/client-go#267 should have fixed the client go failure, odd, if this is blocking work I think we can override the client-go issue

@JoelSpeed
Copy link
Contributor Author

/test verify-client-go

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 5, 2023

@JoelSpeed: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 74f9448 into openshift:master Dec 5, 2023
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.15.0-202312051932.p0.g74f9448.assembly.stream for distgit ose-cluster-config-api.
All builds following this will include this PR.

@theobarberbany theobarberbany mentioned this pull request Mar 7, 2024
Closed
@JoelSpeed JoelSpeed deleted the disable-disable-kubelet-cloud-credential-providers branch January 28, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees Awaiting requested review from bparees

@sjenning sjenning Awaiting requested review from sjenning

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@elmiko elmiko

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JoelSpeed @elmiko @openshift-ci-robot @soltysh @sairameshv @openshift-bot