Skip to content

Commit 74f9448

Browse files
Merge pull request #1693 from JoelSpeed/disable-disable-kubelet-cloud-credential-providers
Set DisableKubeletCloudCredentialProviders upstream feature gate to False
2 parents b5716b3 + 5fe3654 commit 74f9448

File tree

2 files changed

+18
-3
lines changed

2 files changed

+18
-3
lines changed

config/v1/feature_gates.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -381,4 +381,14 @@ var (
381381
ResponsiblePerson: "djoshy",
382382
OwningProduct: ocpSpecific,
383383
}
384+
385+
FeatureGateDisableKubeletCloudCredentialProviders = FeatureGateName("DisableKubeletCloudCredentialProviders")
386+
disableKubeletCloudCredentialProviders = FeatureGateDescription{
387+
FeatureGateAttributes: FeatureGateAttributes{
388+
Name: FeatureGateDisableKubeletCloudCredentialProviders,
389+
},
390+
OwningJiraComponent: "cloud-provider",
391+
ResponsiblePerson: "jspeed",
392+
OwningProduct: kubernetes,
393+
}
384394
)

config/v1/types_feature.go

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,8 +159,10 @@ type FeatureGateEnabledDisabled struct {
159159
var FeatureSets = map[FeatureSet]*FeatureGateEnabledDisabled{
160160
Default: defaultFeatures,
161161
CustomNoUpgrade: {
162-
Enabled: []FeatureGateDescription{},
163-
Disabled: []FeatureGateDescription{},
162+
Enabled: []FeatureGateDescription{},
163+
Disabled: []FeatureGateDescription{
164+
disableKubeletCloudCredentialProviders, // We do not currently ship the correct config to use the external credentials provider.
165+
},
164166
},
165167
TechPreviewNoUpgrade: newDefaultFeatures().
166168
with(validatingAdmissionPolicy).
@@ -189,6 +191,7 @@ var FeatureSets = map[FeatureSet]*FeatureGateEnabledDisabled{
189191
with(sdnLiveMigration).
190192
with(mixedCPUsAllocation).
191193
with(managedBootImages).
194+
without(disableKubeletCloudCredentialProviders).
192195
toFeatures(defaultFeatures),
193196
LatencySensitive: newDefaultFeatures().
194197
toFeatures(defaultFeatures),
@@ -207,7 +210,9 @@ var defaultFeatures = &FeatureGateEnabledDisabled{
207210
privateHostedZoneAWS,
208211
buildCSIVolumes,
209212
},
210-
Disabled: []FeatureGateDescription{},
213+
Disabled: []FeatureGateDescription{
214+
disableKubeletCloudCredentialProviders, // We do not currently ship the correct config to use the external credentials provider.
215+
},
211216
}
212217

213218
type featureSetBuilder struct {

0 commit comments

Comments
 (0)