8370865: Incorrect parser error for compact source files and multi-variable declarations

[lahodaj]

Consider code like:

int f1, f2;
void main() {}

When javac's parser accepts f1, it sees ,, but it won't parse this as top-level field declarations, failing with:

/tmp/F.java:1: error: class, interface, annotation type, enum, record, method or field expected
int f1, f2;
^
1 error

This PR changes the parser to also accept the , as the next token when parsing top-level fields.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8370865: Incorrect parser error for compact source files and multi-variable declarations (Bug - P3)

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28044/head:pull/28044
$ git checkout pull/28044

Update a local copy of the PR:
$ git checkout pull/28044
$ git pull https://git.openjdk.org/jdk.git pull/28044/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28044

View PR using the GUI difftool:
$ git pr show -t 28044

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28044.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370865: Incorrect parser error for compact source files and multi-variable declarations

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 58 new commits pushed to the master branch:

• 8236800: 8370527: Memory leak after 8316694: Implement relocation of nmethod within CodeCache
• 16dafc0: 8370393: Cleanup handling of ancient Windows versions from GetJavaProperties java_props_md
• 2158719: 8370150: Add StrictMath microbenchmarks to cover FDLIBM algorithms
• ... and 55 more: https://git.openjdk.org/jdk/compare/c97d50d793df46292e38707956586dfaa4b77d32...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (814d9753)

[vicente-romero-oracle]

lgtm

[lahodaj]

/integrate

[openjdk]

Going to push as commit abf4f3d.
Since your change was applied there have been 78 commits pushed to the master branch:

• 15fd529: 8366196: Crash in AbstractMethodCheck.getMethodCheckFailure
• 667744c: 8370794: C2 SuperWord: Long/Integer.compareUnsigned return wrong value for EQ/NE in SLP
• deb7edb: 8366017: Extend the set of inputs handled by fast paths in FloatingDecimal
• ... and 75 more: https://git.openjdk.org/jdk/compare/c97d50d793df46292e38707956586dfaa4b77d32...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj Pushed as commit abf4f3d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.