8366196: Crash in AbstractMethodCheck.getMethodCheckFailure

Reviewed-by: liach, mcimadamore

Author: lahodaj

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/AttrRecover.java

@@ -34,6 +34,8 @@
 import com.sun.tools.javac.code.TypeTag;
 import com.sun.tools.javac.code.Types;
 import com.sun.tools.javac.comp.Attr.ResultInfo;
+import com.sun.tools.javac.comp.Check.CheckContext;
+import com.sun.tools.javac.comp.Check.NestedCheckContext;
 import com.sun.tools.javac.comp.DeferredAttr.AttrMode;
 import com.sun.tools.javac.tree.JCTree;
 import com.sun.tools.javac.tree.JCTree.JCBlock;
@@ -66,6 +68,7 @@ public class AttrRecover {
     protected static final Context.Key<AttrRecover> attrRepairKey = new Context.Key<>();
 
     final Attr attr;
+    final Check chk;
     final DeferredAttr deferredAttr;
     final Names names;
     final TreeMaker make;
@@ -84,6 +87,7 @@ protected AttrRecover(Context context) {
         context.put(attrRepairKey, this);
 
         attr = Attr.instance(context);
+        chk = Check.instance(context);
         deferredAttr = DeferredAttr.instance(context);
         names = Names.instance(context);
         make = TreeMaker.instance(context);
@@ -192,8 +196,14 @@ public void visitClassDef(JCClassDecl tree) {
                 while (pats.length() < args.length()) {
                     pats = pats.append(syms.errType);
                 }
+                CheckContext recoveryCheckContext = new NestedCheckContext(todo.resultInfo.checkContext) {
+                    @Override
+                    public void report(JCDiagnostic.DiagnosticPosition pos, JCDiagnostic details) {
+                        chk.basicHandler.report(pos, details);
+                    }
+                };
                 owntype = attr.checkMethod(todo.site, todo.candSym,
-                                 attr.new ResultInfo(todo.resultInfo.pkind, todo.resultInfo.pt.getReturnType(), todo.resultInfo.checkContext, todo.resultInfo.checkMode),
+                                 attr.new ResultInfo(todo.resultInfo.pkind, todo.resultInfo.pt.getReturnType(), recoveryCheckContext, todo.resultInfo.checkMode),
                                  todo.env, args, pats,
                                  todo.resultInfo.pt.getTypeArguments());
                 rollback.forEach(Runnable::run);

test/langtools/tools/javac/recovery/AttrRecovery.java

@@ -23,7 +23,7 @@
 
 /*
  * @test
- * @bug 8301580 8322159 8333107 8332230 8338678 8351260
+ * @bug 8301580 8322159 8333107 8332230 8338678 8351260 8366196
  * @summary Verify error recovery w.r.t. Attr
  * @library /tools/lib
  * @modules jdk.compiler/com.sun.tools.javac.api
@@ -340,4 +340,58 @@ void test(List<@AlphaChars <@StringLength(int value = 5)String> s){
             .run(Expect.FAIL)
             .writeAll();
     }
+
+
+    @Test //JDK-8366196
+    public void testInferenceFailure() throws Exception {
+        String code = """
+                      import module java.base;
+                      public class Test {
+                          public void test(Consumer<String> c) {
+                            List.of("")
+                                .stream()
+                                .filter(
+                                    buildPredicate(
+                                        String.class,
+                                        //missing supplier
+                                        c,
+                                        buildSupplier(
+                                            // Missing: Class,
+                                            Integer.class,
+                                            String.class,
+                                            i -> { int check; return i; })));
+                          }
+
+                          private static <T> Predicate<T> buildPredicate(
+                              Class<T> tClass,
+                              Supplier<T> bSupplier,
+                              Consumer<T> cConsumer,
+                              Supplier<T> dSupplier) {
+                            return null;
+                          }
+
+                          private static <T, A, B> Supplier<String> buildSupplier(
+                              Class<T> tClass, Class<A> aClass, Class<B> bClass,
+                              Function<A, B> function) {
+                            return null;
+                          }
+                      }""";
+        Path curPath = Path.of(".");
+        List<String> actual = new JavacTask(tb)
+                .options("-XDrawDiagnostics", "-XDshould-stop.at=FLOW")
+                .sources(code)
+                .outdir(curPath)
+                .run(Expect.FAIL)
+                .writeAll()
+                .getOutputLines(OutputKind.DIRECT);
+
+        List<String> expected = List.of(
+                "Test.java:7:29: compiler.err.prob.found.req: (compiler.misc.infer.no.conforming.assignment.exists: T, (compiler.misc.inconvertible.types: java.util.function.Consumer<java.lang.String>, java.util.function.Supplier<T>))",
+                "1 error"
+        );
+
+        if (!Objects.equals(actual, expected)) {
+            error("Expected: " + expected + ", but got: " + actual);
+        }
+    }
 }