Skip to content

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Jun 27, 2025

Hi all,

This pull request contains a backport of commit 334683e6 from the openjdk/jdk repository.

The commit being backported was authored by David Holmes on 26 Jun 2025 and was reviewed by Fredrik Bredberg, Aleksey Shipilev and Daniel D. Daugherty.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8358645: Access violation in ThreadsSMRSupport::print_info_on during thread dump (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26010/head:pull/26010
$ git checkout pull/26010

Update a local copy of the PR:
$ git checkout pull/26010
$ git pull https://git.openjdk.org/jdk.git pull/26010/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26010

View PR using the GUI difftool:
$ git pr show -t 26010

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26010.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 27, 2025

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into jdk25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 27, 2025

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358645: Access violation in ThreadsSMRSupport::print_info_on during thread dump

Reviewed-by: shade, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the jdk25 branch:

  • 926c900: 8359830: Incorrect os.version reported on macOS Tahoe 26 (Beta)

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk25 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk25 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 334683e634c23a3672585e4309a528d0944d942e 8358645: Access violation in ThreadsSMRSupport::print_info_on during thread dump Jun 27, 2025
@openjdk
Copy link

openjdk bot commented Jun 27, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Jun 27, 2025
@openjdk
Copy link

openjdk bot commented Jun 27, 2025

@dholmes-ora The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jun 27, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 27, 2025
@dholmes-ora
Copy link
Member Author

Thanks for the review @shipilev !

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up. This patch is identical to the main-line version.

@dholmes-ora
Copy link
Member Author

Thanks for the review @dcubed-ojdk !

/integrate

@openjdk
Copy link

openjdk bot commented Jun 30, 2025

Going to push as commit 0dc9e84.
Since your change was applied there have been 3 commits pushed to the jdk25 branch:

  • 12ffb0c: 8359761: JDK 25 RDP1 L10n resource files update
  • eaaaae5: 8356708: C2: loop strip mining expansion doesn't take sunk stores into account
  • 926c900: 8359830: Incorrect os.version reported on macOS Tahoe 26 (Beta)

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 30, 2025
@openjdk openjdk bot closed this Jun 30, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 30, 2025
@openjdk
Copy link

openjdk bot commented Jun 30, 2025

@dholmes-ora Pushed as commit 0dc9e84.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required hotspot-runtime [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants