Fix gutter ads, move in-game add to bottom right corner.

[evanpelle]

Description:

Move the in-game add to underneath the control panel, ensure both are 320px.

Remove black squares on home page when user has ad blocker

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory
• I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced
• I understand that submitting code with bugs that could have been caught through manual testing blocks releases and new features for all contributors

Please put your Discord username so you can be contacted if a bug or regression is found:

openfront

[coderabbitai]

Walkthrough

This update revises the layout and styling for ad and control panel components. It adjusts error handling and rendering logic in the gutter ad modal, changes container widths and backgrounds, and restructures the bottom UI to stack the control panel and left ad vertically in a fixed-width column. No public API changes were made.

Changes

File(s)	Change Summary
src/client/GutterAdModal.ts	Improved error handling by hiding modal on ad load failure; updated rendering to conditionally style ad containers and removed loading text. Adjusted z-index and background color.
src/client/graphics/layers/ControlPanel.ts, src/client/graphics/layers/LeftInGameAd.ts	Changed container widths to fixed 320px, updated background colors and shadows, removed z-index and pointer event classes from left ad.
src/client/index.html	Changed bottom UI layout: now stacks control panel and left ad in a centered, fixed-width column; removed duplicate left ad instance.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant GutterAdModal
    participant window.ramp

    User->>GutterAdModal: loadAds()
    alt window.ramp is not available
        GutterAdModal->>GutterAdModal: hide()
    else window.ramp is available
        GutterAdModal->>window.ramp: load ad
        alt Ad load throws error
            GutterAdModal->>GutterAdModal: hide()
        else Ad loads successfully
            GutterAdModal->>GutterAdModal: display ad
        end
    end

Loading

Possibly related PRs

• Create in-game Ad #853: Introduced the LeftInGameAd component and its original integration into the UI, which is directly modified here.
• add playwire ads #1128: Added the GutterAdModal and Playwire ad integration, whose rendering and error handling logic are updated in this PR.

Suggested labels

UI/UX

Poem

A column stands where once was row,
With ads and panels all in tow.
No loading text, just space and air,
New shadows, corners, everywhere.
If ads won't load, the modal flees—
The UI now is sure to please!
🖼️✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-06-18T02_19_07_826Z-debug-0.log

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7085a1a and 2055103.

📒 Files selected for processing (4)

• src/client/GutterAdModal.ts (3 hunks)
• src/client/graphics/layers/ControlPanel.ts (1 hunks)
• src/client/graphics/layers/LeftInGameAd.ts (1 hunks)
• src/client/index.html (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (4)

• src/client/index.html
• src/client/graphics/layers/LeftInGameAd.ts
• src/client/GutterAdModal.ts
• src/client/graphics/layers/ControlPanel.ts

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Deploy to openfront.dev

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.