Skip to content

Fix gutter ads, move in-game add to bottom right corner. #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evanpelle merged 1 commit into from
Jun 18, 2025
Merged

Fix gutter ads, move in-game add to bottom right corner. #1214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 6 additions & 16 deletions src/client/GutterAdModal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ export class GutterAdModal extends LitElement {

if (!window.ramp) {
console.warn("Playwire RAMP not available");
this.hide();
return;
}

Expand All @@ -82,6 +83,7 @@ export class GutterAdModal extends LitElement {
});
} catch (error) {
console.error("Failed to load Playwire ads:", error);
this.hide();
}
}

Expand Down Expand Up @@ -109,36 +111,24 @@ export class GutterAdModal extends LitElement {
return html`
<!-- Left Gutter Ad -->
<div
class="hidden xl:flex fixed left-0 top-1/2 transform -translate-y-1/2 w-[160px] min-h-[600px] bg-gray-900 border border-gray-600 z-[9999] pointer-events-auto items-center justify-center shadow-lg"
class="hidden xl:flex fixed left-0 top-1/2 transform -translate-y-1/2 w-[160px] min-h-[600px] z-[10] pointer-events-auto items-center justify-center"
style="margin-left: ${this.margin};"
>
<div
id="${this.leftContainerId}"
class="w-full h-full flex items-center justify-center p-2"
>
${!this.adLoaded
? html`<span class="text-white text-xs text-center"
>Loading ad...</span
>`
: ""}
</div>
></div>
</div>

<!-- Right Gutter Ad -->
<div
class="hidden xl:flex fixed right-0 top-1/2 transform -translate-y-1/2 w-[160px] min-h-[600px] bg-gray-900 border border-gray-600 z-[9999] pointer-events-auto items-center justify-center shadow-lg"
class="hidden xl:flex fixed right-0 top-1/2 transform -translate-y-1/2 w-[160px] min-h-[600px] z-[10] pointer-events-auto items-center justify-center"
style="margin-right: ${this.margin};"
>
<div
id="${this.rightContainerId}"
class="w-full h-full flex items-center justify-center p-2"
>
${!this.adLoaded
? html`<span class="text-white text-xs text-center"
>Loading ad...</span
>`
: ""}
</div>
></div>
</div>
`;
}
Expand Down
2 changes: 1 addition & 1 deletion src/client/graphics/layers/ControlPanel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ export class ControlPanel extends LitElement implements Layer {
</style>
<div
class="${this._isVisible
? "w-full text-sm lg:text-m lg:w-72 bg-slate-800/40 backdrop-blur-sm shadow-xs p-2 pr-3 lg:p-4 shadow-lg lg:rounded-lg"
? "w-[320px] text-sm lg:text-m bg-gray-800/70 p-2 pr-3 lg:p-4 shadow-lg lg:rounded-lg backdrop-blur"
: "hidden"}"
@contextmenu=${(e) => e.preventDefault()}
>
Expand Down
2 changes: 1 addition & 1 deletion src/client/graphics/layers/LeftInGameAd.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export class LeftInGameAd extends LitElement implements Layer {

return html`
<div
class="w-full min-h-[100px] bg-gray-900 border border-gray-600 z-[9999] pointer-events-auto flex items-center justify-center"
class="w-[320px] min-h-[100px] bg-gray-900 border border-gray-600 flex items-center justify-center"
>
<div
id="${AD_CONTAINER_ID}"
Expand Down
10 changes: 6 additions & 4 deletions src/client/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,15 +272,18 @@
style="position: fixed; pointer-events: none"
>
<div
class="w-full sm:w-2/3 sm:fixed sm:right-0 sm:bottom-0 sm:flex justify-end"
class="w-full sm:w-2/3 sm:fixed sm:right-0 sm:bottom-0 sm:flex flex-col items-end"
style="pointer-events: none"
>
<chat-display></chat-display>
<events-display></events-display>
</div>
<div class="w-full sm:w-1/3 md:max-w-72" style="pointer-events: auto">
<left-in-game-ad></left-in-game-ad>
<div
class="w-[320px] flex flex-col items-center"
style="pointer-events: auto"
>
<control-panel></control-panel>
<left-in-game-ad></left-in-game-ad>
</div>
</div>

Expand Down Expand Up @@ -364,7 +367,6 @@
<multi-tab-modal></multi-tab-modal>
<unit-info-modal></unit-info-modal>
<news-modal></news-modal>
<left-in-game-ad></left-in-game-ad>
<game-left-sidebar></game-left-sidebar>
<div
id="language-modal"
Expand Down
Loading