build: mark --enable-heterogeneous as experimental #9815
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: #9697 (comment) Bug: https://bugs.gentoo.org/828123 Signed-off-by: Sam James <[email protected]>
|
Can one of the admins verify this patch? |
|
@thesamesam Thanks! Check out the conversation on #9811 (particularly starting with #9811 (comment)) -- I'm trying to get clarity from @bosilca (one of the main maintainers of the heterogeneous stuff in Open MPI) on what exactly it is that we should do. Let's see what the resolution is over there. |
gpaulsen
requested review from
AboorvaDevarajan,
bosilca and
jsquyres
and removed request for
AboorvaDevarajan
|
@thesamesam Thanks for this PR! I have a few updates for you:
I think the above PRs should make this PR moot. |
|
@thesamesam Are you ok with me closing this PR / is the text we added to the README's elsewhere sufficient? |
|
Hi @jsquyres! Really appreciate the summary. I think it looks plenty clear to me now! Thanks a lot for your help here 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this change is accepted, we should do something similar for 4.0.x too.
@jsquyres has very kindly updated the downstream Gentoo bug and the READMEs in the repository to avoid anyone enabling this option downstream, but I think adding this to the
./configure --helptext will be useful too.We could possibly add a warning to the
./configureoutput too (some projects do this if they don't "like" a configuration that's been used / it's experimental) but this is probably enough? Let me know what you think.Bug: #9697 (comment)
Bug: https://bugs.gentoo.org/828123
Signed-off-by: Sam James [email protected]